[REFT]: update CreatePipelineRequest to use models and add validation

Author: legendary-acp

backend/internal/frontend/pipeline/handler.go

@@ -36,13 +36,18 @@ func (f *FrontendPipelineHandler) GetAllPipelines(w http.ResponseWriter, r *http
 }
 
 func (f *FrontendPipelineHandler) CreatePipeline(w http.ResponseWriter, r *http.Request) {
-	var req CreatePipelineRequest
+	var req models.CreatePipelineRequest
 
 	if err := utils.UnmarshalJSONRequest(r, &req); err != nil {
 		utils.SendJSONError(w, http.StatusBadRequest, fmt.Sprintf("Invalid payload: %v", err))
 		return
 	}
 
+	if err := utils.ValidatePipelineRequest(&req); err != nil {
+		utils.SendJSONError(w, http.StatusBadRequest, fmt.Sprintf("Invalid pipeline request: %v", err))
+		return
+	}
+
 	utils.Logger.Info(fmt.Sprintf("Received request to create pipeline: %s", req.Name))
 
 	pipelineId, err := f.FrontendPipelineService.CreatePipeline(req)

backend/internal/frontend/pipeline/model.go

@@ -1,14 +1,5 @@
 package frontendpipeline
 
-import "github.com/ctrlb-hq/ctrlb-control-plane/backend/internal/models"
-
-type CreatePipelineRequest struct {
-	Name          string               `json:"name"`
-	CreatedBy     string               `json:"created_by"`
-	AgentIDs      []int                `json:"agent_ids"`
-	PipelineGraph models.PipelineGraph `json:"pipeline_graph"`
-}
-
 type Pipeline struct {
 	ID            int    `json:"id"`
 	Name          string `json:"name"`

backend/internal/frontend/pipeline/repository.go

@@ -79,7 +79,7 @@ func (f *FrontendPipelineRepository) GetPipelineInfo(pipelineId int) (*PipelineI
 	return pipelineInfo, nil
 }
 
-func (f *FrontendPipelineRepository) CreatePipeline(createPipelineRequest CreatePipelineRequest) (string, error) {
+func (f *FrontendPipelineRepository) CreatePipeline(createPipelineRequest models.CreatePipelineRequest) (string, error) {
 	tx, err := f.db.Begin()
 	if err != nil {
 		return "", fmt.Errorf("failed to begin transaction: %w", err)

backend/internal/frontend/pipeline/service.go

@@ -34,7 +34,7 @@ func (f *FrontendPipelineService) GetPipelineInfo(pipelineId int) (*PipelineInfo
 	return f.FrontendPipelineRepository.GetPipelineInfo(pipelineId)
 }
 
-func (f *FrontendPipelineService) CreatePipeline(createPipelineRequest CreatePipelineRequest) (string, error) {
+func (f *FrontendPipelineService) CreatePipeline(createPipelineRequest models.CreatePipelineRequest) (string, error) {
 	return f.FrontendPipelineRepository.CreatePipeline(createPipelineRequest)
 }
 

backend/internal/models/pipeline.go

@@ -1,5 +1,12 @@
 package models
 
+type CreatePipelineRequest struct {
+	Name          string        `json:"name"`
+	CreatedBy     string        `json:"created_by"`
+	AgentIDs      []int         `json:"agent_ids"`
+	PipelineGraph PipelineGraph `json:"pipeline_graph"`
+}
+
 // Struct for pipeline component (Node)
 type PipelineComponent struct {
 	ComponentID   int            `json:"component_id"`

backend/internal/utils/validator.go

@@ -49,3 +49,19 @@ func IsUniqueViolation(err error) bool {
 	}
 	return false
 }
+
+func ValidatePipelineRequest(request *models.CreatePipelineRequest) error {
+	if request.Name == "" {
+		return fmt.Errorf("pipeline name cannot be empty")
+	}
+	if request.CreatedBy == "" {
+		return fmt.Errorf("created by cannot be empty")
+	}
+	if request.PipelineGraph.Nodes == nil {
+		return fmt.Errorf("pipeline nodes cannot be empty")
+	}
+	if request.PipelineGraph.Edges == nil {
+		return fmt.Errorf("pipeline edges cannot be empty")
+	}
+	return nil
+}