Skip to content

Commit 303933a

Browse files
author
Andy Beverley
committed
Validate widget configuration
1 parent cd0a819 commit 303933a

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

lib/GADS/Schema/Result/Widget.pm

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,25 @@ sub before_create
126126
}
127127
}
128128

129+
sub is_integer
130+
{ $_[0] =~ /^[0-9]+$/;
131+
}
132+
129133
sub validate
130134
{ my $self = shift;
131135
$self->type('notice') if !$self->type; # XXX Temp until widget type can be defined
132136
$self->type =~ /^(notice|table|graph|timeline|globe)$/
133137
or error __x"Invalid widget type: {type}", type => $self->type;
138+
! defined $self->h || is_integer($self->h)
139+
or error __x"Invalid h value {value}", value => $self->h;
140+
! defined $self->w || is_integer($self->w)
141+
or error __x"Invalid w value {value}", value => $self->w;
142+
! defined $self->x || is_integer($self->x)
143+
or error __x"Invalid x value {value}", value => $self->x;
144+
! defined $self->y || is_integer($self->y)
145+
or error __x"Invalid y value {value}", value => $self->y;
146+
! defined $self->rows || is_integer($self->rows)
147+
or error __x"Invalid rows value {value}", value => $self->rows;
134148
}
135149

136150
sub html

0 commit comments

Comments
 (0)