Ensure that the private key is not accidentally sent to the frontend

Author: timlegge

lib/GADS.pm

@@ -1777,9 +1777,33 @@ any ['get', 'post'] => '/authentication_providers/:id' => require_any_role [qw/u
             { 'label_plain' => 'builtin', value => 'builtin'},
     );
 
+    # This is required to ensure we do not accidentally pass the
+    # private key to the frontend - we could allow the admin
+    # to update the key and cert manually by displaying an empty
+    # sp_key field in the template;
+    my %provider = (
+            name                  => $editProvider->name,
+            type                  => $editProvider->type,
+            saml2_firstname       => $editProvider->saml2_firstname,
+            saml2_surname         => $editProvider->saml2_surname,
+            xml                   => $editProvider->xml,
+            cacert                => $editProvider->cacert,
+            sp_cert               => $editProvider->sp_cert,
+            saml2_relaystate      => $editProvider->saml2_relaystate,
+            saml2_groupname       => $editProvider->saml2_groupname,
+            saml2_unique_id       => $editProvider->saml2_unique_id,
+            sso_url               => $editProvider->sso_url,
+            sso_xml               => $editProvider->sso_xml,
+            enabled               => $editProvider->enabled,
+            sp_key                => '',
+            id                    => $editProvider->id,
+            site_id               => $editProvider->site_id,
+            error_messages        => $editProvider->error_messages,
+    );
+
     # FIXME need to revise what is passed to the template
     my $output = template 'authentication/provider_edit' => {
-        editprovider => $editProvider,
+        editprovider => \%provider,
         groups   => GADS::Groups->new(schema => schema)->all,
         values   => {
             type	  => \@types,