Deprecate request promise #8233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
github-actions
bot
added
the
pr:community
|
@jlloyd-widen Thanks for contributing to this one! I'd suggest we go with |
jlloyd-widen
force-pushed
the
deprecate-request-promise
branch
from
5deb677 to
9468f90
Compare
|
@paveltiunov Thanks for the guidance. I have updated the PR to use |
jlloyd-widen
force-pushed
the
deprecate-request-promise
branch
from
f47125e to
d0c6481
Compare
…precate-request-promise
KSDaemon
reviewed
Dec 12, 2024
Comment on lines
+91
to
+92
| deploymentId: '' as any, | ||
| url: '' as any, |
|
Hi @jlloyd-widen Thnx for the contribution! I left a minor notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
Resolves #8204
Description of Changes Made (if issue reference is not provided)
The
requestandrequest-promisepackages were removed in favor ofrock-req(https://github.com/carboneio/rock-req). This aims to resolve dependence on deprecated packages and the vulnerabilities associated with them. However, this has not attempted to remove the offending packages from devDependencies (i.e., in the schema compiler).Note: I'm not convinced the unit testing strategy is sufficient to prove that these changes haven't broken anything because unit tests typically mock the
rock-reqpackage. Will attempt to test locally with an active cube.js instance.