Skip to content

Commit 18adcd2

Browse files
authored
Merge pull request #34 from cube-root/fix-node-core-library
Fix node core library
2 parents 18d049a + 6da1178 commit 18adcd2

5 files changed

Lines changed: 113 additions & 10 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ npx directory-serve ~/Desktop -p=3000 --username=test --password=password
7575

7676
### prerequisite
7777

78-
1. Node (>=14.0)
78+
1. Node (>=12.0)
7979

8080
<br/>
8181
clone the repo and follow the commands

lib/helper/network.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
/* eslint-disable consistent-return */
33
/* eslint-disable no-restricted-syntax */
44

5-
const os = require('node:os');
5+
const os = require('os');
66

77
const networkInterfaces = os.networkInterfaces();
88

lib/middleware/index.js

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,20 @@
1-
const querystring = require('node:querystring');
1+
const queryString = require('query-string');
22
const { directory } = require('./directory');
33
const { fileUpload } = require('./file-upload');
44
const { fileRemove } = require('./file-remove');
55
const { authMiddleware } = require('./auth');
66

7-
const handler = (req, res, { path, uploadFile = true, deleteFile = false } = {}) => {
8-
if (req.query.file && req.query.delete && req.query.delete.toLowerCase() === 'true' && deleteFile) {
7+
const handler = (
8+
req,
9+
res,
10+
{ path, uploadFile = true, deleteFile = false } = {},
11+
) => {
12+
if (
13+
req.query.file
14+
&& req.query.delete
15+
&& req.query.delete.toLowerCase() === 'true'
16+
&& deleteFile
17+
) {
918
return fileRemove(req, res, {
1019
// path: `${path.replace(/[/]$/, '')}/${req.path.replace(/^[/]/, '')}`,
1120
path,
@@ -14,7 +23,7 @@ const handler = (req, res, { path, uploadFile = true, deleteFile = false } = {})
1423
}
1524

1625
if (req.method === 'POST' && uploadFile) {
17-
const query = querystring.decode(req.url, null, null);
26+
const query = queryString.parse(req.url);
1827
if (query && !query.path) {
1928
return res.status(500).send('Invalid path');
2029
}

package-lock.json

Lines changed: 94 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "directory-serve",
3-
"version": "1.3.2",
3+
"version": "1.3.3",
44
"description": "Command line tool to share the directory",
55
"main": "./bin/index.js",
66
"scripts": {
@@ -34,7 +34,7 @@
3434
"url": "git+https://github.com/cube-root/directory-serve.git"
3535
},
3636
"engines": {
37-
"node": ">=14.0"
37+
"node": ">=12.0"
3838
},
3939
"directories": {
4040
"bin": "./bin",
@@ -53,8 +53,10 @@
5353
"express": "^4.18.2",
5454
"formidable": "^2.0.1",
5555
"fs-extra": "^10.1.0",
56+
"os": "^0.1.2",
5657
"parseurl": "^1.3.3",
5758
"qrcode-terminal": "^0.12.0",
59+
"query-string": "^7.1.1",
5860
"send": "^0.18.0",
5961
"yargs": "^17.6.0"
6062
},

0 commit comments

Comments
 (0)