Skip to content

Commit f912e86

Browse files
rachitnigamrachitnigam
committed
lint checks for conv impls
1 parent 66a82b2 commit f912e86

File tree

6 files changed

+952
-77
lines changed

6 files changed

+952
-77
lines changed

‎apps/guass-pyramid/ready-val/conv/conv2d_1.v‎

Lines changed: 73 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
/*verilator lint_off DECLFILENAME*/
2+
/*verilator lint_off ASCRANGE*/
3+
/*verilator lint_off UNUSEDPARAM*/
4+
/*verilator lint_off PROCASSINIT*/
5+
/*verilator lint_off WIDTHEXPAND*/
6+
/*verilator lint_off WIDTHTRUNC*/
7+
/*verilator lint_off UNUSEDSIGNAL*/
8+
/*verilator lint_off UNDRIVEN*/
19
module stupleToSSeq_tSSeq_3_Int__n3 (
210
input [7:0] I_0_0,
311
input [7:0] I_0_1,
@@ -12643,42 +12651,72 @@ module top (
1264312651
assign valid_down = FIFO_tSSeq_16_Int__delay1_hasCEFalse_hasResetFalse_hasValidTrue_inst3_valid_down;
1264412652
endmodule
1264512653

12654+
/*verilator lint_on ASCRANGE*/
12655+
/*verilator lint_on UNUSEDPARAM*/
12656+
/*verilator lint_on PROCASSINIT*/
12657+
/*verilator lint_on WIDTHEXPAND*/
12658+
/*verilator lint_on WIDTHTRUNC*/
12659+
/*verilator lint_on UNUSEDSIGNAL*/
12660+
/*verilator lint_on UNDRIVEN*/
1264612661
module Conv2d (
1264712662
input clk,
12648-
input [7:0] I_0,
12649-
input [7:0] I_1,
12650-
input [7:0] I_10,
12651-
input [7:0] I_11,
12652-
input [7:0] I_12,
12653-
input [7:0] I_13,
12654-
input [7:0] I_14,
12655-
input [7:0] I_15,
12656-
input [7:0] I_2,
12657-
input [7:0] I_3,
12658-
input [7:0] I_4,
12659-
input [7:0] I_5,
12660-
input [7:0] I_6,
12661-
input [7:0] I_7,
12662-
input [7:0] I_8,
12663-
input [7:0] I_9,
12664-
output [7:0] O_0,
12665-
output [7:0] O_1,
12666-
output [7:0] O_10,
12667-
output [7:0] O_11,
12668-
output [7:0] O_12,
12669-
output [7:0] O_13,
12670-
output [7:0] O_14,
12671-
output [7:0] O_15,
12672-
output [7:0] O_2,
12673-
output [7:0] O_3,
12674-
output [7:0] O_4,
12675-
output [7:0] O_5,
12676-
output [7:0] O_6,
12677-
output [7:0] O_7,
12678-
output [7:0] O_8,
12679-
output [7:0] O_9
12663+
input valid_i,
12664+
input [15:0][7:0] I,
12665+
12666+
output valid_o,
12667+
output [15:0][7:0] O
1268012668
);
1268112669

12670+
logic [7:0] I_0 = I[0];
12671+
logic [7:0] I_1 = I[1];
12672+
logic [7:0] I_2 = I[2];
12673+
logic [7:0] I_3 = I[3];
12674+
logic [7:0] I_4 = I[4];
12675+
logic [7:0] I_5 = I[5];
12676+
logic [7:0] I_6 = I[6];
12677+
logic [7:0] I_7 = I[7];
12678+
logic [7:0] I_8 = I[8];
12679+
logic [7:0] I_9 = I[9];
12680+
logic [7:0] I_10 = I[10];
12681+
logic [7:0] I_11 = I[11];
12682+
logic [7:0] I_12 = I[12];
12683+
logic [7:0] I_13 = I[13];
12684+
logic [7:0] I_14 = I[14];
12685+
logic [7:0] I_15 = I[15];
12686+
12687+
logic [7:0] O_0;
12688+
assign O[0] = O_0;
12689+
logic [7:0] O_1;
12690+
assign O[1] = O_1;
12691+
logic [7:0] O_2;
12692+
assign O[2] = O_2;
12693+
logic [7:0] O_3;
12694+
assign O[3] = O_3;
12695+
logic [7:0] O_4;
12696+
assign O[4] = O_4;
12697+
logic [7:0] O_5;
12698+
assign O[5] = O_5;
12699+
logic [7:0] O_6;
12700+
assign O[6] = O_6;
12701+
logic [7:0] O_7;
12702+
assign O[7] = O_7;
12703+
logic [7:0] O_8;
12704+
assign O[8] = O_8;
12705+
logic [7:0] O_9;
12706+
assign O[9] = O_9;
12707+
logic [7:0] O_10;
12708+
assign O[10] = O_10;
12709+
logic [7:0] O_11;
12710+
assign O[11] = O_11;
12711+
logic [7:0] O_12;
12712+
assign O[12] = O_12;
12713+
logic [7:0] O_13;
12714+
assign O[13] = O_13;
12715+
logic [7:0] O_14;
12716+
assign O[14] = O_14;
12717+
logic [7:0] O_15;
12718+
assign O[15] = O_15;
12719+
1268212720
top t (
1268312721
.clk,
1268412722
.I_0,
@@ -12713,8 +12751,8 @@ top t (
1271312751
.O_7,
1271412752
.O_8,
1271512753
.O_9,
12716-
.valid_up(1'd1),
12717-
.valid_down()
12754+
.valid_up(valid_i),
12755+
.valid_down(valid_o)
1271812756
);
1271912757

12720-
endmodule
12758+
endmodule

‎apps/guass-pyramid/ready-val/conv/conv2d_16.v‎

Lines changed: 26 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
/*verilator lint_off DECLFILENAME*/
2+
/*verilator lint_off ASCRANGE*/
3+
/*verilator lint_off UNUSEDPARAM*/
4+
/*verilator lint_off PROCASSINIT*/
5+
/*verilator lint_off WIDTHEXPAND*/
6+
/*verilator lint_off WIDTHTRUNC*/
7+
/*verilator lint_off UNUSEDSIGNAL*/
8+
/*verilator lint_off UNDRIVEN*/
19
module stupleToSSeq_tInt_n3 (
210
input [7:0] I_0,
311
input [7:0] I_1,
@@ -4809,18 +4817,31 @@ module top (
48094817
assign valid_down = FIFO_tTSeq_16_0_SSeq_1_Int___delay1_hasCEFalse_hasResetFalse_hasValidTrue_inst3_valid_down;
48104818
endmodule
48114819

4820+
/*verilator lint_on ASCRANGE*/
4821+
/*verilator lint_on PROCASSINIT*/
4822+
/*verilator lint_on WIDTHEXPAND*/
4823+
/*verilator lint_on WIDTHTRUNC*/
4824+
/*verilator lint_on UNUSEDSIGNAL*/
4825+
/*verilator lint_on UNDRIVEN*/
48124826
module Conv2d (
48134827
input clk,
4814-
input [7:0] I_0,
4815-
output [7:0] O_0
4828+
input valid_i,
4829+
input [7:0] I,
4830+
4831+
output valid_o,
4832+
output [7:0] O
48164833
);
48174834

4835+
logic [7:0] I_0 = I;
4836+
logic [7:0] O_0;
4837+
assign O = O_0;
4838+
48184839
top t (
48194840
.clk(clk),
4820-
.valid_up(1'd1),
4841+
.valid_up(valid_i),
48214842
.I_0(I_0),
48224843
.O_0(O_0),
4823-
.valid_down()
4844+
.valid_down(valid_o)
48244845
);
48254846

4826-
endmodule
4847+
endmodule

‎apps/guass-pyramid/ready-val/conv/conv2d_2.v‎

Lines changed: 49 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
/*verilator lint_off DECLFILENAME*/
2+
/*verilator lint_off ASCRANGE*/
3+
/*verilator lint_off UNUSEDPARAM*/
4+
/*verilator lint_off PROCASSINIT*/
5+
/*verilator lint_off WIDTHEXPAND*/
6+
/*verilator lint_off WIDTHTRUNC*/
7+
/*verilator lint_off UNUSEDSIGNAL*/
8+
/*verilator lint_off UNDRIVEN*/
19
module stupleToSSeq_tSSeq_3_Int__n3 (
210
input [7:0] I_0_0,
311
input [7:0] I_0_1,
@@ -10522,28 +10530,50 @@ module top (
1052210530
assign valid_down = FIFO_tTSeq_2_0_SSeq_8_Int___delay1_hasCEFalse_hasResetFalse_hasValidTrue_inst3_valid_down;
1052310531
endmodule
1052410532

10533+
/*verilator lint_on ASCRANGE*/
10534+
/*verilator lint_on UNUSEDPARAM*/
10535+
/*verilator lint_on PROCASSINIT*/
10536+
/*verilator lint_on WIDTHEXPAND*/
10537+
/*verilator lint_on WIDTHTRUNC*/
10538+
/*verilator lint_on UNUSEDSIGNAL*/
10539+
/*verilator lint_on UNDRIVEN*/
1052510540
module Conv2d (
1052610541
input clk,
10527-
input [7:0] I_0,
10528-
input [7:0] I_1,
10529-
input [7:0] I_2,
10530-
input [7:0] I_3,
10531-
input [7:0] I_4,
10532-
input [7:0] I_5,
10533-
input [7:0] I_6,
10534-
input [7:0] I_7,
10535-
output [7:0] O_0,
10536-
output [7:0] O_1,
10537-
output [7:0] O_2,
10538-
output [7:0] O_3,
10539-
output [7:0] O_4,
10540-
output [7:0] O_5,
10541-
output [7:0] O_6,
10542-
output [7:0] O_7
10542+
input valid_i,
10543+
output valid_o,
10544+
input [7:0][7:0] I,
10545+
output [7:0][7:0] O
1054310546
);
10547+
10548+
logic [7:0] I_0 = I[0];
10549+
logic [7:0] I_1 = I[1];
10550+
logic [7:0] I_2 = I[2];
10551+
logic [7:0] I_3 = I[3];
10552+
logic [7:0] I_4 = I[4];
10553+
logic [7:0] I_5 = I[5];
10554+
logic [7:0] I_6 = I[6];
10555+
logic [7:0] I_7 = I[7];
10556+
10557+
logic [7:0] O_0;
10558+
assign O[0] = O_0;
10559+
logic [7:0] O_1;
10560+
assign O[1] = O_1;
10561+
logic [7:0] O_2;
10562+
assign O[2] = O_2;
10563+
logic [7:0] O_3;
10564+
assign O[3] = O_3;
10565+
logic [7:0] O_4;
10566+
assign O[4] = O_4;
10567+
logic [7:0] O_5;
10568+
assign O[5] = O_5;
10569+
logic [7:0] O_6;
10570+
assign O[6] = O_6;
10571+
logic [7:0] O_7;
10572+
assign O[7] = O_7;
10573+
1054410574
top t (
10545-
.valid_up(1'd1),
10546-
.valid_down(),
10575+
.valid_up(valid_i),
10576+
.valid_down(valid_o),
1054710577
.clk(clk),
1054810578
.I_0(I_0),
1054910579
.I_1(I_1),
@@ -10562,4 +10592,4 @@ top t (
1056210592
.O_6(O_6),
1056310593
.O_7(O_7)
1056410594
);
10565-
endmodule
10595+
endmodule

‎apps/guass-pyramid/ready-val/conv/conv2d_4.v‎

Lines changed: 37 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
/*verilator lint_off DECLFILENAME*/
2+
/*verilator lint_off ASCRANGE*/
3+
/*verilator lint_off UNUSEDPARAM*/
4+
/*verilator lint_off PROCASSINIT*/
5+
/*verilator lint_off WIDTHEXPAND*/
6+
/*verilator lint_off WIDTHTRUNC*/
7+
/*verilator lint_off UNUSEDSIGNAL*/
8+
/*verilator lint_off UNDRIVEN*/
19
module stupleToSSeq_tSSeq_3_Int__n3 (
210
input [7:0] I_0_0,
311
input [7:0] I_0_1,
@@ -6942,21 +6950,39 @@ module top (
69426950
assign valid_down = FIFO_tTSeq_4_0_SSeq_4_Int___delay1_hasCEFalse_hasResetFalse_hasValidTrue_inst3_valid_down;
69436951
endmodule
69446952

6953+
/*verilator lint_on ASCRANGE*/
6954+
/*verilator lint_on UNUSEDPARAM*/
6955+
/*verilator lint_on PROCASSINIT*/
6956+
/*verilator lint_on WIDTHEXPAND*/
6957+
/*verilator lint_on WIDTHTRUNC*/
6958+
/*verilator lint_on UNUSEDSIGNAL*/
6959+
/*verilator lint_on UNDRIVEN*/
69456960
module Conv2d (
69466961
input clk,
6947-
input [7:0] I_0,
6948-
input [7:0] I_1,
6949-
input [7:0] I_2,
6950-
input [7:0] I_3,
6951-
output [7:0] O_0,
6952-
output [7:0] O_1,
6953-
output [7:0] O_2,
6954-
output [7:0] O_3
6962+
input valid_i,
6963+
input [3:0][7:0] I,
6964+
6965+
output valid_o,
6966+
output [3:0][7:0] O
69556967
);
69566968

6969+
logic [7:0] I_0 = I[0];
6970+
logic [7:0] I_1 = I[1];
6971+
logic [7:0] I_2 = I[2];
6972+
logic [7:0] I_3 = I[3];
6973+
6974+
logic [7:0] O_0;
6975+
assign O[0] = O_0;
6976+
logic [7:0] O_1;
6977+
assign O[1] = O_1;
6978+
logic [7:0] O_2;
6979+
assign O[2] = O_2;
6980+
logic [7:0] O_3;
6981+
assign O[3] = O_3;
6982+
69576983
top t (
69586984
.clk(clk),
6959-
.valid_up(1'd1),
6985+
.valid_up(valid_i),
69606986
.I_0(I_0),
69616987
.I_1(I_1),
69626988
.I_2(I_2),
@@ -6965,7 +6991,7 @@ top t (
69656991
.O_1(O_1),
69666992
.O_2(O_2),
69676993
.O_3(O_3),
6968-
.valid_down()
6994+
.valid_down(valid_o)
69696995
);
69706996

6971-
endmodule
6997+
endmodule

‎apps/guass-pyramid/ready-val/conv/conv2d_8.v‎

Lines changed: 31 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
/*verilator lint_off DECLFILENAME*/
2+
/*verilator lint_off ASCRANGE*/
3+
/*verilator lint_off UNUSEDPARAM*/
4+
/*verilator lint_off PROCASSINIT*/
5+
/*verilator lint_off WIDTHEXPAND*/
6+
/*verilator lint_off WIDTHTRUNC*/
7+
/*verilator lint_off UNUSEDSIGNAL*/
8+
/*verilator lint_off UNDRIVEN*/
19
module stupleToSSeq_tSSeq_3_Int__n3 (
210
input [7:0] I_0_0,
311
input [7:0] I_0_1,
@@ -5341,22 +5349,38 @@ module top (
53415349
assign valid_down = FIFO_tTSeq_8_0_SSeq_2_Int___delay1_hasCEFalse_hasResetFalse_hasValidTrue_inst3_valid_down;
53425350
endmodule
53435351

5352+
/*verilator lint_on ASCRANGE*/
5353+
/*verilator lint_on UNUSEDPARAM*/
5354+
/*verilator lint_on PROCASSINIT*/
5355+
/*verilator lint_on WIDTHEXPAND*/
5356+
/*verilator lint_on WIDTHTRUNC*/
5357+
/*verilator lint_on UNUSEDSIGNAL*/
5358+
/*verilator lint_on UNDRIVEN*/
53445359
module Conv2d (
53455360
input clk,
5346-
input [7:0] I_0,
5347-
input [7:0] I_1,
5348-
output [7:0] O_0,
5349-
output [7:0] O_1
5361+
input valid_i,
5362+
input [1:0][7:0] I,
5363+
5364+
output valid_o,
5365+
output [1:0][7:0] O
53505366
);
53515367

5368+
logic [7:0] I_0 = I[0];
5369+
logic [7:0] I_1 = I[1];
5370+
5371+
logic [7:0] O_0;
5372+
assign O[0] = O_0;
5373+
logic [7:0] O_1;
5374+
assign O[1] = O_1;
5375+
53525376
top t (
53535377
.clk(clk),
5354-
.valid_up(1'd1),
5355-
.valid_down(),
5378+
.valid_up(valid_i),
5379+
.valid_down(valid_o),
53565380
.I_0(I_0),
53575381
.I_1(I_1),
53585382
.O_0(O_0),
53595383
.O_1(O_1)
53605384
);
53615385

5362-
endmodule
5386+
endmodule

0 commit comments

Comments
 (0)