Skip to content

Commit 2756b0a

Browse files
authored
Merge pull request #228 from cucumber/feature/ruby+bump
[Ruby] Minimum version bump
2 parents f5e8f25 + e4040ce commit 2756b0a

18 files changed

+284
-176
lines changed

.github/workflows/release-github.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
---
22
name: Release on github
33

4-
on: # yamllint disable-line rule:truthy
4+
on:
55
push:
66
branches:
77
- release/*
88

99
jobs:
10-
1110
pre-release-check:
1211
uses: cucumber/ci-environment/.github/workflows/prerelease-checks.yml@main
1312

@@ -18,7 +17,6 @@ jobs:
1817
environment: Release
1918
permissions:
2019
contents: write
21-
2220
steps:
2321
- uses: actions/checkout@v4
2422
- uses: cucumber/[email protected]

.github/workflows/release-java.yml

+1-5
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
---
22
name: Release maven package
33

4-
on: # yamllint disable-line rule:truthy
4+
on:
55
push:
66
branches:
77
- release/*
88

99
jobs:
10-
1110
pre-release-check:
1211
uses: cucumber/ci-environment/.github/workflows/prerelease-checks.yml@main
1312

@@ -19,16 +18,13 @@ jobs:
1918
needs: [pre-release-check, test-java]
2019
runs-on: ubuntu-latest
2120
environment: Release
22-
2321
steps:
2422
- uses: actions/checkout@v4
25-
2623
- uses: actions/setup-java@v3
2724
with:
2825
distribution: 'temurin'
2926
java-version: '11'
3027
cache: 'maven'
31-
3228
- uses: cucumber/[email protected]
3329
with:
3430
gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }}

.github/workflows/release-javascript.yml

+1-6
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
---
22
name: Release ci-environment npm module
33

4-
on: # yamllint disable-line rule:truthy
4+
on:
55
push:
66
branches:
77
- release/*
88

99
jobs:
10-
1110
pre-release-check:
1211
uses: cucumber/ci-environment/.github/workflows/prerelease-checks.yml@main
1312

@@ -19,19 +18,15 @@ jobs:
1918
needs: [pre-release-check, test-javascript]
2019
runs-on: ubuntu-latest
2120
environment: Release
22-
2321
steps:
2422
- uses: actions/checkout@v4
25-
2623
- uses: actions/setup-node@v4
2724
with:
2825
node-version: 18
2926
cache: 'npm'
3027
cache-dependency-path: javascript/package-lock.json
31-
3228
- run: npm install-ci-test
3329
working-directory: javascript
34-
3530
- uses: cucumber/[email protected]
3631
with:
3732
npm-token: ${{ secrets.NPM_TOKEN }}

.github/workflows/release-ruby.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
---
22
name: Release ci-environment ruby gem
33

4-
on: # yamllint disable-line rule:truthy
4+
on:
55
push:
66
branches:
77
- release/*
88

99
jobs:
10-
1110
pre-release-check:
1211
uses: cucumber/ci-environment/.github/workflows/prerelease-checks.yml@main
1312

.github/workflows/test-go.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: test-go
3-
on: # yamllint disable-line rule:truthy
3+
on:
44
push:
55
branches:
66
- main

.github/workflows/test-java.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: test-java
33

4-
on: # yamllint disable-line rule:truthy
4+
on:
55
push:
66
branches:
77
- main

.github/workflows/test-javascript.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: test-javascript
33

4-
on: # yamllint disable-line rule:truthy
4+
on:
55
push:
66
branches:
77
- main

.github/workflows/test-python.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: test-python
33

4-
on: # yamllint disable-line rule:truthy
4+
on:
55
push:
66
branches:
77
- main
@@ -13,13 +13,11 @@ on: # yamllint disable-line rule:truthy
1313

1414
jobs:
1515
build:
16-
1716
runs-on: ubuntu-latest
1817
timeout-minutes: 20
1918
strategy:
2019
matrix:
2120
python-version: ["3.8", "3.9", "3.10", "3.11"]
22-
2321
steps:
2422
- uses: actions/checkout@v4
2523
- name: Set up Python ${{ matrix.python-version }}

.github/workflows/test-ruby.yml

+6-8
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: test-ruby
33

4-
on: # yamllint disable-line rule:truthy
4+
on:
55
push:
66
branches:
77
- main
@@ -19,22 +19,20 @@ jobs:
1919
matrix:
2020
os:
2121
- ubuntu-latest
22-
ruby: [3.1, 3.2]
22+
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
2323
include:
2424
- os: windows-latest
25-
ruby: 3.2
25+
ruby: '3.2'
2626
- os: macos-latest
27-
ruby: 3.2
27+
ruby: '3.2'
2828

2929
steps:
3030
- uses: actions/checkout@v4
31-
- name: Set up Ruby
32-
uses: ruby/setup-ruby@v1
31+
- uses: ruby/setup-ruby@v1
3332
with:
3433
ruby-version: ${{ matrix.ruby }}
3534
bundler-cache: true
3635
working-directory: ruby
37-
- name: bundle exec rake
36+
- run: bundle exec rake
3837
working-directory: ruby
39-
run: bundle exec rake
4038
- run: ./scripts/fail-if-dirty

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
88
## [Unreleased]
99
### Added
1010
- [Python] added ci-environment implementation in Python
11+
- [Ruby] Initial rubocop configuration added ([#228](https://github.com/cucumber/ci-environment/pull/228))
12+
13+
### Changed
14+
- [Ruby] Minimum ruby version is now 2.6 ([#228](https://github.com/cucumber/ci-environment/pull/228))
1115

1216
## [9.2.0] - 2023-04-28
1317
### Added

ruby/.rubocop.yml

+27
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
inherit_from: .rubocop_todo.yml
2+
3+
require:
4+
- rubocop-performance
5+
- rubocop-rake
6+
- rubocop-rspec
7+
8+
AllCops:
9+
TargetRubyVersion: 2.6
10+
NewCops: enable
11+
12+
# Disabled on our repo's to enable polyglot-release
13+
Gemspec/RequireMFA:
14+
Enabled: false
15+
16+
Layout/LineLength:
17+
Max: 200
18+
19+
Style/Documentation:
20+
Enabled: false
21+
22+
Style/RegexpLiteral:
23+
EnforcedStyle: slashes
24+
AllowInnerSlashes: true
25+
26+
RSpec/MessageSpies:
27+
EnforcedStyle: receive

0 commit comments

Comments
 (0)