Skip to content

glue and features globbing respects files.exclude but not search.exclude #250

Open
@abrenneke

Description

👓 What did you see?

In our monorepo, we have node_modules included in search.exclude but not files.exclude so that node_modules shows up in the file tree in the editor.

However, this causes the rg processes that the extension spawns to take foreeevver because they don't include -g !**/node_modules which means that rg is scanning the entire (gigabytes) node_modules folder.

Adding **/node_modules to files.exclude solves the performance problem we're running into.

✅ What did you expect to see?

I'd expect one of:

  1. Globbing respects search.exclude
  2. Have the ability to add ignore paths to the globbing to speed it up
  3. Automatically ignore **/node_modules?

📦 Which tool/library version are you using?

Cucumber for Visual Studio Code v1.10.0

🔬 How could we reproduce it?

Not really reproducible without a massive node_modules that takes upwards of 10 seconds to scan using rg. But you can note the arguments that are used in the rg process match files.exclude but not search.exclude.

📚 Any additional context?

I tried adding !**/node_modules to cucumber.features and cucumber.glue but unfortunately this gets translated to -g /!**/node_modules which doesn't successfully negate.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions