Hyperlink support

[voidray]

Still to be implemented regarding hyperlinks:

• Copying text with hyperlinks doesn't work yet. Only text and formatting is copied.
• Pasting hyperlinks from another application
• Support for remaining formats (RTF, ...)
• Ability to create/modify/delete shortcuts with a simple UI (overlay or dialog window)
• Default hyperlink color not well readable in dark theme

[cuikp]

Will visit this issue later, thanks.

[cuikp]

Ah yes, copying/pasting is via rtf so that won't work yet until Rtf handles hyperlinks. I will try to work on that tonight.

[cuikp]

Seems RtfDomParser does not parse out the hyperlink Uri

({{\field{{\*\fldinst HYPERLINK).... }

although it retrieves the inner text (displayed text of hyperlink).
So I'm going to have to modify RtfDomParser (again) so it will do so. Could take a day or two -

[voidray]

Thanks, it would be great if you could take a look at the RTF part. I created a PR for adding/editing/deleting hyperlinks: #40

[voidray]

When using the dark theme, the default blue hyperlink color is difficult to read. Could you take a at the changes in this branch that introduces a HyperlinkBrush property, if that is something worth adding in this way?
voidray@c27563d

[cuikp]

Those changes are probably a good idea.

I just tested Word and seems it allows total control over hyperlink formatting, despite the initial (blue/underline). I had assumed hyperlink formatting was supposed to stay put, but apparently not.

I haven't tested how user-changes to hyperlink formatting are handled by WPF RichTextBox (which is fundamentally what AvRichTextBox is "designed" to mimic), but it probably allows them too.

Maybe forcing formatting is not the way to go then, just set the initial formatting when a hyperlink is created, and let the user/developer do what they want afterwards?

[voidray]

I don't know about how WPF RichTextBox handles it, but I also think that the hyperlink color shouldn't be forced, but there should be a default, that ideally can be set by the developer. For example with the mentioned changes this could be set, to use the default color: HyperlinkBrush="{DynamicResource HyperlinkButtonForeground}"
For me custom color for hyperlinks would not be a high priority, but I wouldn't be opposed to it. If there is a way to check if a user has formatted the hyperlink with a different color, then I think it would be best to not save the color when exporting rtf/html/... if it wasn't changed (at least for html, where there is a default color).

[voidray]

There is an issue with copying hyperlinks: When only the hyperlink itself is selected nothing is copied. It only works if something to the left of the hyperlink is also selected (even one character to the left is enough).

[cuikp]

You're right - Selecting hyperlink from it's exact start fails to copy it properly (exact end is ok). This also is due to how I recently modified the way Inline contexts are defined.

So will try to fix this ASAP as it also happens with copying at the start of some paragraphs.

[cuikp]

Regarding hyperlink formatting, I think yes, just define initial default formatting when creating the hyperlink, but treat it just like any other EditableRun after that (fully customizable, saved and loaded as is).

[cuikp]

After a little tinkering, seems the failure to copy when selecting hyperlink from start is an rtf parsing issue, not an Inline context issue... (the \field keyword isn't picked up unless it has text before it). So maybe more work on RtfDomParser, we'll see.

[cuikp]

Latest push fixes copying hyperlink from its start (either selecting just the hyperlink or the hyperlink + anything after that).