Merge pull request #445 from cultuurnet/PPF-726-dont-create-users

PPF-726 don't create users on UiTIDv1

Author: JonasVHG

src/Project/CommandHandler/CreateProjectCommandHandler.php

@@ -159,50 +159,19 @@ public function handle(CreateProject $createProject)
         $this->logger->debug('Finished handling CreateProject for ' . $createProject->getName());
     }
 
-    /**
-     * Create a user on test if that user does not exist yet.
-     */
-    private function createTestUser($nick, $email)
-    {
-        $searchQuery = new \CultureFeed_SearchUsersQuery();
-        $searchQuery->mbox = $email;
-        $searchQuery->mboxIncludePrivate = true;
-        /** @var \CultureFeed_ResultSet $result */
-        $result = $this->cultureFeedTest->searchUsers($searchQuery);
-
-        // The user already exists?
-        if ($result->total > 0) {
-            return $result->objects[0]->id;
-        }
-
-        $user = new \CultureFeed_User();
-        $user->mbox = $email;
-        $user->nick = $nick;
-        $user->password = $this->generatePassword();
-        $user->status = \CultureFeed_User::STATUS_PRIVATE;
-
-        return $this->cultureFeedTest->createUser($user);
-    }
-
     /**
      * Create the test consumer, and add the user as admin.
      * @param CreateProject $createProject
      */
     private function createTestConsumer(CreateProject $createProject, IntegrationType $integrationType)
     {
-        // Make sure the user also exists on test.
-        $uid = $this->createTestUser($this->user->getUsername(), $this->user->mbox);
-
         // Create test consumer.
         $createConsumer = new \CultureFeed_Consumer();
         $createConsumer->name = $createProject->getName();
         $createConsumer->description = $createProject->getDescription();
         $createConsumer->group = $integrationType->getUitIdPermissionGroups();
         $cultureFeedConsumer = $this->cultureFeedTest->createServiceConsumer($createConsumer);
 
-        // Add the user as service consumer admin.
-        $this->cultureFeedTest->addServiceConsumerAdmin($cultureFeedConsumer->consumerKey, $uid);
-
         // Add uitpas permission to consumer
         $this->cultureFeedTest->addUitpasPermission($cultureFeedConsumer, $integrationType->getUitPasPermissionGroups());
 

test/Project/CommandHandler/CreateProjectCommandHandlerTest.php

@@ -153,12 +153,6 @@ private function setupHandleTest($uid)
             ->with($cultureFeedConsumer)
             ->willReturn($culturefeedTestconsumer);
 
-        // It should add user as admin.
-        $this->cultureFeedTest
-            ->expects($this->once())
-            ->method('addServiceConsumerAdmin')
-            ->with($culturefeedTestconsumer->consumerKey, $uid);
-
         // It should create a live consumer.
         $this->cultureFeed
             ->expects($this->once())
@@ -211,69 +205,6 @@ public function testHandle()
 
         $this->setupHandleTest('testuserid');
 
-        // It should search for a user on test.
-        $searchQuery = new \CultureFeed_SearchUsersQuery();
-        $searchQuery->mbox = 'test@test.be';
-        $searchQuery->mboxIncludePrivate = true;
-        $result = new \CultureFeed_ResultSet();
-        $result->total = 0;
-        $this->cultureFeedTest
-            ->expects($this->once())
-            ->method('searchUsers')
-            ->with($searchQuery)
-            ->willReturn($result);
-
-        // It should add a new test user.
-        $this->commandHandler
-            ->expects($this->once())
-            ->method('generatePassword')
-            ->willReturn('password');
-
-        $newUser = new \CultureFeed_User();
-        $newUser->mbox = 'test@test.be';
-        $newUser->nick = 'test';
-        $newUser->password = 'password';
-        $newUser->status = \CultureFeed_User::STATUS_PRIVATE;
-        $this->cultureFeedTest
-            ->expects($this->once())
-            ->method('createUser')
-            ->with($newUser)
-            ->willReturn('testuserid');
-
-        $createProject = new CreateProject('Project name', 'Project description', 123, 'coupon');
-        $this->commandHandler->handle($createProject);
-    }
-
-    /**
-     * Test the command handler when test user does not exist yet.
-     */
-    public function testHandleNewTestUser()
-    {
-
-        $this->setupHandleTest(20);
-
-        $searchQuery = new \CultureFeed_SearchUsersQuery();
-        $searchQuery->mbox = 'test@test.be';
-        $searchQuery->mboxIncludePrivate = true;
-        $result = new \CultureFeed_ResultSet();
-        $user = new \stdClass();
-        $user->id = '20';
-        $result->total = 1;
-        $result->objects = [
-            $user,
-        ];
-
-        // It should find a user and never create a user.
-        $this->cultureFeedTest
-            ->expects($this->once())
-            ->method('searchUsers')
-            ->with($searchQuery)
-            ->willReturn($result);
-
-        $this->cultureFeedTest
-            ->expects($this->never())
-            ->method('createUser');
-
         $createProject = new CreateProject('Project name', 'Project description', 123, 'coupon');
         $this->commandHandler->handle($createProject);
     }