Skip to content

Improve Claude Code prompting#2147

Merged
lucwollants merged 23 commits intomasterfrom
claude-code-prompt
Feb 3, 2026
Merged

Improve Claude Code prompting#2147
lucwollants merged 23 commits intomasterfrom
claude-code-prompt

Conversation

@lucwollants
Copy link
Contributor

@lucwollants lucwollants commented Jan 29, 2026

Added

  • Added basic docs regarding architecture, coding guidelines, and review guidelines to give AI tools a context to work in
  • Added a CLAUDE.md file that points to the various detailed docs so it's easy to switch to another tool

Changed

  • Move the review guidelines into a dedicated file

@lucwollants
Copy link
Contributor Author

@claude review

claude[bot]

This comment was marked as spam.

@cultuurnet cultuurnet deleted a comment from claude bot Jan 29, 2026
@lucwollants
Copy link
Contributor Author

@claude review

@claude
Copy link
Contributor

claude bot commented Jan 29, 2026

Claude finished @lucwollants's task in 2m 8s —— View job


Review Complete

  • Read repository guidelines (CLAUDE.md)
  • Start pending review
  • Fetch and analyze PR diff
  • Review documentation files
  • Add inline comments with suggestions
  • Submit review
  • Provide final summary

Summary

Reviewed the PR and provided inline feedback on 8 specific areas. The documentation structure is well-organized with clear separation between quick reference (CLAUDE.md) and detailed docs. The workflow simplification improves maintainability.

Key findings:

  • SAPI3 setup documentation is missing (referenced in multiple docs but no setup instructions)
  • AI restrictions in coding-guidelines.md conflict with Claude GitHub Action behavior
  • Workflow now only triggers on issue comments (manual-only mode)
  • Several opportunities for minor enhancements around failure scenarios, logging guidance, and codebase-specific review checks

All feedback has been posted as inline review comments with actionable suggestions where applicable.


claude[bot]

This comment was marked as off-topic.

@lucwollants lucwollants marked this pull request as ready for review January 29, 2026 13:56
@lucwollants lucwollants merged commit 626f419 into master Feb 3, 2026
4 checks passed
@lucwollants lucwollants deleted the claude-code-prompt branch February 3, 2026 13:18
Copy link
Contributor

@grubolsch grubolsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this is amazing work.
Also kinda funny we add documentation now for machines.

@lucwollants
Copy link
Contributor Author

wow, this is amazing work. Also kinda funny we add documentation now for machines.

We can also still use it, but maybe this becomes less relevant because we will write less and less code and focus more on providing added value for our customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants