Fix DeprecationWarning caused by mixing valkey and redis classes

The `DeprecationWarning` is:

```
DeprecationWarning: Call to 'get_connection' function
with deprecated usage of input argument/s '['command_name']'.
(Use get_connection() without args instead) -- Deprecated since version 5.3.0.
```

Author: kurtmckee

fakeredis/_connection.py

@@ -11,7 +11,27 @@
 from ._typing import Self, lib_version, RaiseErrorTypes, VersionType, ServerType
 
 
-class FakeConnection(FakeBaseConnectionMixin, redis.Connection):
+class FakeConnection(FakeBaseConnectionMixin):
+    manifested_connection_classes = {}
+
+    def __new__(cls, *args: Any, **kwargs: Any) -> "FakeConnection":
+        """Inherit dynamically from the correct Connection class.
+
+        Currently, only Valkey is a special case.
+        """
+
+        connection_class = kwargs.get("connection_class", redis.Connection)
+
+        if connection_class not in cls.manifested_connection_classes:
+            module_name, _, _ = connection_class.__module__.partition(".")
+            new_class_name = f"Fake{module_name.title()}Connection"
+            base_class = type(new_class_name, (cls, connection_class), {})
+            cls.manifested_connection_classes[connection_class] = base_class
+        else:
+            base_class = cls.manifested_connection_classes[connection_class]
+
+        return object.__new__(base_class)
+
     def __init__(*args: Any, **kwargs: Any) -> None:
         FakeBaseConnectionMixin.__init__(*args, **kwargs)
 
@@ -148,7 +168,14 @@ def __init__(
                 "client_class": client_class,
             }
             connection_kwargs.update({arg: kwds[arg] for arg in conn_pool_args if arg in kwds})
-            kwds["connection_pool"] = redis.connection.ConnectionPool(**connection_kwargs)
+            if server_type == "valkey":
+                import valkey.connection
+
+                valkey_pool = valkey.connection.ConnectionPool(**connection_kwargs)
+                kwds["connection_pool"] = valkey_pool
+            else:
+                redis_pool = redis.connection.ConnectionPool(**connection_kwargs)
+                kwds["connection_pool"] = redis_pool
         kwds.pop("server", None)
         kwds.pop("connected", None)
         kwds.pop("version", None)

fakeredis/_valkey.py

@@ -17,6 +17,7 @@ def _validate_server_type(args_dict: Dict[str, Any]) -> None:
 class FakeValkey(FakeRedisMixin, valkey.Valkey):
     def __init__(self, *args: Any, **kwargs: Any) -> None:
         _validate_server_type(kwargs)
+        kwargs["connection_class"] = valkey.Connection
         super().__init__(*args, **kwargs)
 
     @classmethod
@@ -27,6 +28,7 @@ def from_url(cls, *args: Any, **kwargs: Any) -> Self:
 class FakeStrictValkey(FakeRedisMixin, valkey.StrictValkey):
     def __init__(self, *args: Any, **kwargs: Any) -> None:
         _validate_server_type(kwargs)
+        kwargs["connection_class"] = valkey.Connection
         super(FakeStrictValkey, self).__init__(*args, **kwargs)
 
     @classmethod
@@ -38,6 +40,7 @@ class FakeAsyncValkey(FakeAsyncRedisMixin, valkey.asyncio.Valkey):
     def __init__(self, *args: Any, **kwargs: Any) -> None:
         kwargs.setdefault("client_class", valkey.asyncio.Valkey)
         _validate_server_type(kwargs)
+        kwargs["connection_class"] = valkey.asyncio.connection.Connection
         super(FakeAsyncValkey, self).__init__(*args, **kwargs)
 
     @classmethod

fakeredis/aioredis.py

@@ -111,7 +111,27 @@ def writelines(self, data: Iterable[Any]) -> None:
             self._socket.sendall(chunk)  # type:ignore
 
 
-class FakeConnection(FakeBaseConnectionMixin, redis_async.Connection):
+class FakeConnection(FakeBaseConnectionMixin):
+    manifested_connection_classes = {}
+
+    def __new__(cls, *args: Any, **kwargs: Any) -> "FakeConnection":
+        """Inherit dynamically from the correct Connection class.
+
+        Currently, only Valkey is a special case.
+        """
+
+        connection_class = kwargs.get("connection_class", redis_async.Connection)
+
+        if connection_class not in cls.manifested_connection_classes:
+            module_name, _, _ = connection_class.__module__.partition(".")
+            new_class_name = f"Fake{module_name.title()}Connection"
+            base_class = type(new_class_name, (cls, connection_class), {})
+            cls.manifested_connection_classes[connection_class] = base_class
+        else:
+            base_class = cls.manifested_connection_classes[connection_class]
+
+        return object.__new__(base_class)
+
     async def _connect(self) -> None:
         if not self._server.connected:
             raise redis_async.ConnectionError(msgs.CONNECTION_ERROR_MSG)
@@ -247,7 +267,14 @@ def __init__(
                 "client_class": client_class,
             }
             connection_kwargs.update({arg: kwds[arg] for arg in conn_pool_args if arg in kwds})
-            kwds["connection_pool"] = redis_async.connection.ConnectionPool(**connection_kwargs)  # type: ignore
+            if server_type == "valkey":
+                import valkey.asyncio.connection
+
+                v_pool = valkey.asyncio.connection.ConnectionPool(**connection_kwargs)  # type: ignore
+                kwds["connection_pool"] = v_pool
+            else:
+                r_pool = redis_async.connection.ConnectionPool(**connection_kwargs)  # type: ignore
+                kwds["connection_pool"] = r_pool
         kwds.pop("server", None)
         kwds.pop("connected", None)
         kwds.pop("version", None)