Skip to content

Two potential bugs regarding bookmarking apps? #60

Open
@pmoulos

Description

@pmoulos

Hi,

Firstly, thanks for this excellent package! It made the whole auth0 setup so much easier and also gave ideas how to use httr with other authentication services.

Now, I think I have identified, two, if not bugs, then potential enhancements:

  1. When using bookmarks, Shiny adds _state_id_ in the bookmark URL. If we then logout (through the logout_url function for example), the logout redirect URI that is created contains _state_id_. If the user immediately logs back again, the previous bookmark is restored. I am not sure whether this is a desired behaviour. What if another user logs in with other credentials? Maybe I am missing some technical details here, but from my perspective this is not desirable and I implemented a fix by simply reconstructing the redirect URI without _state_id_ in.

  2. When using the remote_url parameter (in _auth0.yml) for deployment in a remote server and enforcing local is not an option because it would complicate other things (e.g. when using Apache mod_proxy to avoid displaying the Shiny port), bookmarks are not restored. Again, I 've implemented a fix/addition for this.

I 've forked the package and implemented these fixes/additions. You can review here.

If you think it's ok I could create a PR?

Thanks again.

Metadata

Metadata

Assignees

Labels

bookmarkingProblems related to bookmarkingenhancementNew feature or request

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions