fix: can't use Boolean for BN

curvefi · Feb 14, 2025 · 52b0c59 · 52b0c59
1 parent 166ce02
commit 52b0c59
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/pools/mixins/depositBalancedAmountsMixins.ts b/src/pools/mixins/depositBalancedAmountsMixins.ts
@@ -16,12 +16,12 @@ function _depositBalancedAmounts(poolBalances: string[], walletBalances: string[
         ))
     ));
     const firstCoinBalanceForEachScenarioBN = balancedAmountsForEachScenarioBN.map(([a]) => a);
-    const min = BigNumber.min(...firstCoinBalanceForEachScenarioBN.filter(Boolean)); // ignore any coins not present in the wallet
-    const scenarioWithLowestBalancesBN = firstCoinBalanceForEachScenarioBN.map(String).indexOf(min.toString());
 
-    return balancedAmountsForEachScenarioBN[scenarioWithLowestBalancesBN].map(
-        (a, i) => walletBalancesBN[i].isZero() ? "0" : a.toFixed(decimals[i])
-    )
+    // get the scenario with the lowest balances, ignoring scenarios where the wallet balance is zero
+    const min = BigNumber.min(...firstCoinBalanceForEachScenarioBN.filter(b => !b.isZero()));
+    const scenarioWithLowestBalancesBN = firstCoinBalanceForEachScenarioBN.map(String).indexOf(min.toString());
+    const bestScenario = balancedAmountsForEachScenarioBN[scenarioWithLowestBalancesBN];
+    return bestScenario.map((a, i) => walletBalancesBN[i].isZero() ? "0" : a.toFixed(decimals[i]))
 }
 
 // @ts-ignore