Remove git beginTransaction

Author: dantti

demos/async1/coroutines.cpp

@@ -45,7 +45,7 @@ int main(int argc, char *argv[])
 
             auto db = co_await APool::database();
 
-            auto transaction = co_await db->beginTransaction();
+            auto transaction = co_await db->begin();
             qDebug() << "transaction started";
 
             auto result = co_await db->exec(u8"SELECT now()");

src/adatabase.cpp

@@ -122,15 +122,7 @@ bool ADatabase::isOpen() const
     return d != nullptr && d->isOpen();
 }
 
-AExpectedResult ADatabase::begin(QObject *receiver)
-{
-    Q_ASSERT(d);
-    AExpectedResult coro(receiver);
-    d->begin(d, receiver, coro.ref());
-    return coro;
-}
-
-AExpectedTransaction ADatabase::beginTransaction(QObject *receiver)
+AExpectedTransaction ADatabase::begin(QObject *receiver)
 {
     Q_ASSERT(d);
     AExpectedTransaction coro(receiver);

src/adatabase.h

@@ -291,21 +291,13 @@ class ASQL_EXPORT ADatabase
      */
     [[nodiscard]] bool isOpen() const;
 
-    /*!
-     * \brief begin a transaction, this operation usually succeeds,
-     * but one can hook up a callback to check it's result.
-     *
-     * \param cb
-     */
-    [[nodiscard]] AExpectedResult begin(QObject *receiver = nullptr);
-
     /*!
      * \brief begin a transaction with a RAII object, this operation usually succeeds,
      * but one can hook up a callback to check it's result.
      *
      * \param cb
      */
-    [[nodiscard]] AExpectedTransaction beginTransaction(QObject *receiver = nullptr);
+    [[nodiscard]] AExpectedTransaction begin(QObject *receiver = nullptr);
 
     /*!
      * \brief commit a transaction, this operation usually succeeds,

src/amigrations.cpp

@@ -265,7 +265,7 @@ ACoroTerminator AMigrations::migrate(int targetVersion,
         co_return;
     }
 
-    auto t = co_await d->db.beginTransaction();
+    auto t = co_await d->db.begin();
     if (!t) {
         cb(true, t.error());
         co_return;

src/atransaction.cpp

@@ -77,19 +77,6 @@ ATransaction &ATransaction::operator=(const ATransaction &copy)
     return *this;
 }
 
-AExpectedResult ATransaction::begin(QObject *receiver)
-{
-    Q_ASSERT(d);
-    if (!d->running) {
-        d->running = true;
-        return d->db.begin(receiver);
-    } else {
-        qWarning(ASQL_TRANSACTION, "Transaction already started");
-    }
-
-    return {receiver};
-}
-
 AExpectedResult ATransaction::commit(QObject *receiver)
 {
     Q_ASSERT(d);

src/atransaction.h

@@ -48,14 +48,6 @@ class ASQL_EXPORT ATransaction
      */
     static ATransaction fromStarted(const ADatabase &db);
 
-    /*!
-     * \brief begin a transaction, this operation usually succeeds,
-     * but one can hook up a callback to check it's result.
-     *
-     * \param cb
-     */
-    [[nodiscard]] AExpectedResult begin(QObject *receiver = nullptr);
-
     /*!
      * \brief commit a transaction only if our usage count equals 1
      *

tests/sqlite_tst.cpp

@@ -138,7 +138,7 @@ void TestSqlite::testQueries()
             AVERIFY(db);
 
             // TODO use APool::begin() once new coro class is ready
-            auto t = co_await db->beginTransaction(nullptr);
+            auto t = co_await db->begin(nullptr);
             AVERIFY(t);
             AVERIFY(t->database().isValid());