Fix manifest and frame order mismatches in task creations #10134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thanks, I added a test case. Not sure whether it's the right class though |
Contributor
Author
|
Hi @zhiltsov-max, any updates on this |
RavinduWeerakoon
force-pushed
the
manifest-order-fix
branch
from
73c765f to
c2e456a
Compare
|
zhiltsov-max
reviewed
Jan 8, 2026
Comment on lines
+493
to
+494
| (task, _) = api_client.tasks_api.retrieve(task_id) | ||
| assert task.size == 3 |
Contributor
There was a problem hiding this comment.
Probably, it makes sense to also check the resulting file order here. It can be done via the tasks/<id>/data/meta endpoint.
Contributor
|
Please update the existing tests so that the tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
closes #10104
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.
Fixes