Merge with v1.4.1

Author: Dtenwolde

.clang-tidy

@@ -1,4 +1,4 @@
-Checks:          '-*,clang-diagnostic-*,bugprone-*,performance-*,google-explicit-constructor,google-build-using-namespace,google-runtime-int,misc-definitions-in-headers,modernize-use-nullptr,modernize-use-override,-bugprone-macro-parentheses,readability-braces-around-statements,-bugprone-branch-clone,readability-identifier-naming,hicpp-exception-baseclass,misc-throw-by-value-catch-by-reference,-bugprone-signed-char-misuse,-bugprone-misplaced-widening-cast,-bugprone-sizeof-expression,-bugprone-easily-swappable-parameters,google-global-names-in-headers,llvm-header-guard,misc-definitions-in-headers,modernize-use-emplace,modernize-use-bool-literals,-performance-inefficient-string-concatenation,-performance-no-int-to-ptr,readability-container-size-empty,cppcoreguidelines-pro-type-cstyle-cast,-llvm-header-guard,-performance-enum-size,cppcoreguidelines-pro-type-const-cast,cppcoreguidelines-avoid-non-const-global-variables,cppcoreguidelines-interfaces-global-init,cppcoreguidelines-slicing,cppcoreguidelines-rvalue-reference-param-not-moved,cppcoreguidelines-virtual-class-destructor,-readability-identifier-naming,-bugprone-exception-escape,-bugprone-unused-local-non-trivial-variable,-bugprone-empty-catch'
+Checks:          '-*,clang-diagnostic-*,bugprone-*,performance-*,google-explicit-constructor,google-build-using-namespace,google-runtime-int,misc-definitions-in-headers,modernize-use-nullptr,modernize-use-override,-bugprone-macro-parentheses,readability-braces-around-statements,-bugprone-branch-clone,readability-identifier-naming,hicpp-exception-baseclass,misc-throw-by-value-catch-by-reference,-bugprone-signed-char-misuse,-bugprone-misplaced-widening-cast,-bugprone-sizeof-expression,-bugprone-easily-swappable-parameters,google-global-names-in-headers,llvm-header-guard,misc-definitions-in-headers,modernize-use-emplace,modernize-use-bool-literals,-performance-inefficient-string-concatenation,-performance-no-int-to-ptr,readability-container-size-empty,cppcoreguidelines-pro-type-cstyle-cast,-llvm-header-guard,-performance-enum-size,cppcoreguidelines-pro-type-const-cast,cppcoreguidelines-avoid-non-const-global-variables,cppcoreguidelines-interfaces-global-init,cppcoreguidelines-slicing,cppcoreguidelines-rvalue-reference-param-not-moved,cppcoreguidelines-virtual-class-destructor,-readability-identifier-naming,-bugprone-exception-escape,-bugprone-unused-local-non-trivial-variable,-bugprone-empty-catch,-misc-use-internal-linkage,-readability-static-definition-in-anonymous-namespace'
 WarningsAsErrors: '*'
 HeaderFilterRegex: 'src/include/duckdb/.*'
 FormatStyle:     none
@@ -49,4 +49,7 @@ CheckOptions:
     value:           '::duckdb::shared_ptr;::duckdb::unique_ptr;::std::auto_ptr;::duckdb::weak_ptr'
   - key:             cppcoreguidelines-rvalue-reference-param-not-moved.IgnoreUnnamedParams
     value:           true
-
+  - key:             misc-use-internal-linkage
+    value:           true
+  - key:             readability-static-definition-in-anonymous-namespace
+    value:           true

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -14,6 +14,7 @@ body:
             * [duckdb-node](https://github.com/duckdb/duckdb-node/issues/new)
             * [duckdb-node-neo](https://github.com/duckdb/duckdb-node-neo/issues/new)
             * [duckdb-odbc](https://github.com/duckdb/duckdb-odbc/issues/new)
+            * [duckdb-python](https://github.com/duckdb/duckdb-python/issues/new)
             * [duckdb-r](https://github.com/duckdb/duckdb-r/issues/new)
             * [duckdb-rs](https://github.com/duckdb/duckdb-rs/issues/new)
             * [duckdb-swift](https://github.com/duckdb/duckdb-swift/issues/new)

.github/actions/build_extensions/action.yml

@@ -1,3 +1,9 @@
+# # # # # # # # # # # # # # # # # #
+#
+# WARNING: DEPRECATED!
+#
+# # # # # # # # # # # # # # # # # #
+
 name: "Build Extensions"
 description: "Build, test and deploy the DuckDB extensions"
 inputs:
@@ -160,8 +166,6 @@ runs:
 
       run: |
         ls
-        mkdir -p ~/.ssh
-        ssh-keyscan -t rsa github.com >> ~/.ssh/known_hosts
         cd  ${{ inputs.build_dir}}
         ls -al
         pwd
@@ -211,6 +215,7 @@ runs:
       shell: bash
       env:
         LOCAL_EXTENSION_REPO: ${{ inputs.run_autoload_tests == '1' && github.workspace || ''}}
+        DUCKDB_TEST_DESCRIPTION: 'Extension autoloading tests. All `require` calls are ignored and auto-loading is tested. Use require no_extension_autoloading in the test to skip tests.'
       run: |
         cd  ${{ inputs.build_dir}}
         python3 scripts/get_test_list.py --file-contains 'require ' --list '"*.test"' > test.list
@@ -219,6 +224,29 @@ runs:
         rm -rf build/release/extension
         mv build/extension_tmp build/release/extension
 
+    - name: Run tests with auto loading with VS2019 C++ stdlib
+      if: ${{ inputs.run_autoload_tests == '1' && inputs.vcpkg_target_triplet == 'x64-windows-static-md' }}
+      shell: bash
+      env:
+        LOCAL_EXTENSION_REPO: ${{ inputs.run_autoload_tests == '1' && github.workspace || ''}}
+      run: |
+        rm -rf build/extension_tmp
+        mv build/release/extension build/extension_tmp
+        choco install wget -y --no-progress
+        cd  ${{ inputs.build_dir }}
+        TEST_RUNNER_DIR=./build/release/test/Release
+        if [ ! -f ${TEST_RUNNER_DIR}/unittest.exe ]; then
+          echo "Invalid unit tests runner dir: ${TEST_RUNNER_DIR}, check 'inputs.unittest_script' argument"
+          exit 1
+        fi
+        wget -P ${TEST_RUNNER_DIR} https://blobs.duckdb.org/ci/msvcp140.dll
+        ls ${TEST_RUNNER_DIR}
+        # test.list is generated on the previous step
+        ${{ inputs.unittest_script }} '-f test.list'
+        rm ${TEST_RUNNER_DIR}/msvcp140.dll
+        rm -rf ./build/release/extension
+        mv ./build/extension_tmp ./build/release/extension
+
     - name: Deploy
       if: ${{ inputs.deploy_as != '' }}
       shell: bash

.github/actions/build_extensions_dockerized/action.yml

@@ -0,0 +1,7 @@
+if (NOT MINGW)
+    duckdb_extension_load(avro
+            LOAD_TESTS DONT_LINK
+            GIT_URL https://github.com/duckdb/duckdb-avro
+            GIT_TAG 7b75062f6345d11c5342c09216a75c57342c2e82
+    )
+endif()

.github/config/distribution_matrix.json

@@ -0,0 +1,7 @@
+if (NOT MINGW AND NOT ${WASM_ENABLED})
+    duckdb_extension_load(aws
+            ### TODO: re-enable LOAD_TESTS
+            GIT_URL https://github.com/duckdb/duckdb-aws
+            GIT_TAG 18803d5e55b9f9f6dda5047d0fdb4f4238b6801d
+            )
+endif()

.github/config/extensions/avro.cmake

@@ -0,0 +1,7 @@
+if (NOT MINGW AND NOT ${WASM_ENABLED})
+    duckdb_extension_load(azure
+            LOAD_TESTS
+            GIT_URL https://github.com/duckdb/duckdb-azure
+            GIT_TAG 0709c0fa1cf67a668b58b1f06ff3e5fc1696e10a
+            )
+endif()

.github/config/extensions/aws.cmake

@@ -0,0 +1,8 @@
+if (NOT MINGW AND NOT ${WASM_ENABLED})
+    duckdb_extension_load(delta
+            GIT_URL https://github.com/duckdb/duckdb-delta
+            GIT_TAG 03aaf0f073bc622ade27c158d32473588b32aa8b
+            SUBMODULES extension-ci-tools
+            APPLY_PATCHES
+    )
+endif()

.github/config/extensions/azure.cmake

@@ -0,0 +1,5 @@
+duckdb_extension_load(ducklake
+    DONT_LINK
+    GIT_URL https://github.com/duckdb/ducklake
+    GIT_TAG f134ad86f2f6e7cdf4133086c38ecd9c48f1a772
+)