Skip to content

Commit 8df3b6b

Browse files
committed
[wip] need to fix test on views. Update reference to main
1 parent 60dcea3 commit 8df3b6b

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

duckdb

Submodule duckdb updated 591 files

src/core/functions/table/create_property_graph.cpp

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -187,14 +187,14 @@ unique_ptr<FunctionData> CreatePropertyGraphFunction::CreatePropertyGraphBind(Cl
187187
CheckPropertyGraphTableColumns(vertex_table, table);
188188
CheckPropertyGraphTableLabels(vertex_table, table);
189189
} catch (CatalogException &e) {
190-
auto table =
191-
Catalog::GetEntry<ViewCatalogEntry>(context, vertex_table->catalog_name, vertex_table->schema_name,
192-
vertex_table->table_name, OnEntryNotFound::RETURN_NULL);
193-
if (table) {
194-
throw Exception(ExceptionType::INVALID, "Found a view with name " + vertex_table->table_name +
195-
". Creating property graph tables over views is "
196-
"currently not supported.");
197-
}
190+
// auto table =
191+
// Catalog::GetEntry<ViewCatalogEntry>(context, vertex_table->catalog_name, vertex_table->schema_name,
192+
// vertex_table->table_name, OnEntryNotFound::RETURN_NULL);
193+
// if (table) {
194+
// throw Exception(ExceptionType::INVALID, "Found a view with name " + vertex_table->table_name +
195+
// ". Creating property graph tables over views is "
196+
// "currently not supported.");
197+
// }
198198
throw Exception(ExceptionType::INVALID, e.what());
199199
} catch (BinderException &e) {
200200
throw Exception(ExceptionType::INVALID, "Catalog '" + vertex_table->catalog_name + "' does not exist!");
@@ -247,13 +247,13 @@ unique_ptr<FunctionData> CreatePropertyGraphFunction::CreatePropertyGraphBind(Cl
247247
// Validate primary keys in the destination table
248248
ValidatePrimaryKeyInTable(context, edge_table->destination_pg_table, edge_table->destination_pk);
249249
} catch (CatalogException &e) {
250-
auto table = Catalog::GetEntry<ViewCatalogEntry>(context, edge_table->catalog_name, edge_table->schema_name,
251-
edge_table->table_name, OnEntryNotFound::RETURN_NULL);
252-
if (table) {
253-
throw Exception(ExceptionType::INVALID, "Found a view with name " + edge_table->table_name +
254-
". Creating property graph tables over views is "
255-
"currently not supported.");
256-
}
250+
// auto table = Catalog::GetEntry<ViewCatalogEntry>(context, edge_table->catalog_name, edge_table->schema_name,
251+
// edge_table->table_name, OnEntryNotFound::RETURN_NULL);
252+
// if (table) {
253+
// throw Exception(ExceptionType::INVALID, "Found a view with name " + edge_table->table_name +
254+
// ". Creating property graph tables over views is "
255+
// "currently not supported.");
256+
// }
257257
throw Exception(ExceptionType::INVALID, e.what());
258258
} catch (BinderException &e) {
259259
throw Exception(ExceptionType::INVALID, "Catalog '" + edge_table->catalog_name + "' does not exist!");

0 commit comments

Comments
 (0)