Fix tokens not saved to disk after fresh credential login (#342)

On a fresh login, _tokenstore_path was never set on the client before
calling client.login(), so auto-refresh dump() calls never fired and
the token file was never written. Every run forced a full re-login
with MFA regardless of tokenstore path provided.

Fix: normalize tokenstore_path to str upfront, set client._tokenstore_path
before credential login, and explicitly dump tokens after a successful
fresh login.

Reported and fixed by @davidbsandor — thanks!

Co-Authored-By: davidbsandor <davidbsandor@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: 3 people

garminconnect/__init__.py

@@ -1,5 +1,6 @@
 """Python 3 API wrapper for Garmin Connect."""
 
+import contextlib
 import logging
 import numbers
 import os
@@ -420,6 +421,7 @@ def login(self, /, tokenstore: str | None = None) -> tuple[str | None, str | Non
 
             # Try to load tokens from tokenstore if provided
             tokens_loaded = False
+            tokenstore_path = None
             if tokenstore:
                 try:
                     if len(tokenstore) > 512:
@@ -429,9 +431,8 @@ def login(self, /, tokenstore: str | None = None) -> tuple[str | None, str | Non
                         # Tokenstore is a path - normalize it for cross-platform compatibility
                         # This fixes Windows path issues where ~ expansion or path separators
                         # might cause token extraction to not find all token files correctly
-                        tokenstore_path = Path(tokenstore).expanduser().resolve()
-                        # Convert to string with normalized path separators
-                        normalized_path = str(tokenstore_path)
+                        tokenstore_path = str(Path(tokenstore).expanduser().resolve())
+                        normalized_path = tokenstore_path
                         logger.debug(
                             f"Loading tokens from normalized path: {normalized_path}"
                         )
@@ -470,11 +471,17 @@ def login(self, /, tokenstore: str | None = None) -> tuple[str | None, str | Non
                     )
                     # In MFA early-return mode, profile/settings are not loaded yet
                     return mfa_status, _legacy_token
+                if tokenstore_path is not None:
+                    self.client._tokenstore_path = tokenstore_path
                 mfa_status, _legacy_token = self.client.login(
                     self.username,
                     self.password,
                     prompt_mfa=self.prompt_mfa,
                 )
+                # Persist tokens so next run restores without re-login/MFA
+                if tokenstore_path is not None:
+                    with contextlib.suppress(Exception):
+                        self.client.dump(tokenstore_path)
                 # Continue to load profile/settings below
 
             # Ensure profile is loaded (tokenstore path may not populate it)

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "garminconnect"
-version = "0.3.0"
+version = "0.3.1"
 description = "Python 3 API wrapper for Garmin Connect"
 authors = [
     {name = "Ron Klinkien", email = "ron@cyberjunky.nl"},