Skip to content

Commit 4a35f15

Browse files
committed
Copilot PR findings
1 parent 906d839 commit 4a35f15

6 files changed

Lines changed: 7 additions & 4 deletions

File tree

charts/multicluster-ingress/templates/crds/gslbs_multicluster_cyclops_io.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ spec:
3939
items:
4040
type: string
4141
type: array
42-
iPOverrides:
42+
ipOverrides:
4343
description: External IP to return instead of what is in the ingress or service
4444
items:
4545
type: string

charts/multicluster-ingress/templates/crds/gslbs_multicluster_veccsolutions_io.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ spec:
3737
items:
3838
type: string
3939
type: array
40-
iPOverrides:
40+
ipOverrides:
4141
description: External IP to return instead of what is in the ingress or service
4242
items:
4343
type: string

charts/multicluster-ingress/templates/operator-role.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ rules:
6565
verbs:
6666
- get
6767
- apiGroups:
68+
- multicluster.veccsolutions.io
6869
- multicluster.cyclops.io
6970
verbs:
7071
- '*'

src/Cyclops.MultiCluster/Models/Core/ServiceCache.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
using k8s.Models;
2-
using KubeOps.Abstractions.Entities;
3-
using KubeOps.Abstractions.Entities.Attributes;
42

53
namespace Cyclops.MultiCluster.Models.Core
64
{

src/Cyclops.MultiCluster/Models/K8sEntities/V1Gslb.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
using k8s.Models;
22
using KubeOps.Abstractions.Entities;
33
using KubeOps.Abstractions.Entities.Attributes;
4+
using System.Text.Json.Serialization;
45

56
namespace Cyclops.MultiCluster.Models.K8sEntities
67
{
@@ -55,6 +56,7 @@ public class GslbSpec
5556
/// External IP to return instead of what is in the ingress or service
5657
/// </summary>
5758
[Description("External IP to return instead of what is in the ingress or service")]
59+
[JsonPropertyName("ipOverrides")]
5860
public string[]? IPOverrides { get; set; }
5961

6062
/// <summary>

src/Cyclops.MultiCluster/Models/K8sEntities/V1VeccGslb.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
using k8s.Models;
66
using KubeOps.Abstractions.Entities;
77
using KubeOps.Abstractions.Entities.Attributes;
8+
using System.Text.Json.Serialization;
89

910
namespace Cyclops.MultiCluster.Models.K8sEntities
1011
{
@@ -37,6 +38,7 @@ public V1VeccGslb()
3738
/// External IP to return instead of what is in the ingress or service
3839
/// </summary>
3940
[Description("External IP to return instead of what is in the ingress or service")]
41+
[JsonPropertyName("ipOverrides")]
4042
public string[]? IPOverrides { get; set; }
4143

4244
/// <summary>

0 commit comments

Comments
 (0)