amenity=bike_parking area renders over cycleways

[brainwad]

Here, the bike parking polygon is rendering over the cycleway way (but interestingly, not the maxspeed= label). I think the priority should be the other way around?

[brainwad]

Link: https://www.openstreetmap.org/way/1019706711#map=19/47.377385/8.535969&layers=Y

[Phyks]

What is it supposed to look like on ground?

The cycleway is tagged with tunnel, so it is rendered below the area (which is not tagged, so supposed to be on ground floor).

Road labels (and hence maxspeed) is always rendered on top https://github.com/cyclosm/cyclosm-cartocss-style/blob/master/project.mml#L1748-L1867.

I don't remember the exact reason for having such areas hide the underlying ways, but I think I remember this was important for some (other) edge cases :/

[brainwad]

The one at the bottom of the image is indeed ground level parking over a tunnel. However, this tunnel is arguably the most important cycleway in the entire city, so for route legibility I think it really must be shown continuously - especially because the parking areas are occluding an in-tunnel cycleway intersection.

The tunnel rendering would already indicate that it's under the parking area, similar to how a way with tunnel=building_passage renders on top of the buildings that are over the way but with a style that visually represents that it's not in free air.

The one at the top right (Europaplatz) is much worse; the parking area is underground, but it's rendering on top of the above ground ways that run over it (i.e. Europaallee and Kasernestrasse). It has layer=-1 but it doesn't seem to be helping:

[Phyks]

This place is a nightmare in terms of layering haha. Is the default OSM-carto render doing way better in here? (trying to figure out the ideal logic)

Tunnels are rendered before bicycle parking areas (lines 457 < 1364), hence the masking.

This is not the same for the default osm-carto render where areas bicycle parking are rendered as landcover before the tunnels. Then, tunnels cycleways have some extra casing to indicate their underground status.

This would be an easy change technically speaking (in terms of code) but I'm afraid of many possible side effects if not properly controlled.

The other one might be an easier case given we do not filter on layer values in the polygon amenities render: https://github.com/cyclosm/cyclosm-cartocss-style/blob/master/project.mml#L1364-L1409.

However, as per the wiki (https://wiki.openstreetmap.org/wiki/Key:layer):

Negative values do not imply that object is underground, use location=underground for this purpose.

So a blank filtering on layer < 0 would not be a good fit. I guess however that is would be rather safe to not render amenities-poly layer feature when they have location=underground (meaning the label would be rendered but not the actual surface overlay).