Skip to content

Commit a2f29c1

Browse files
committed
Implement all the things
1 parent 6b0b213 commit a2f29c1

4 files changed

Lines changed: 12 additions & 9 deletions

File tree

src/main/java/se/cygni/palmithor/tdd/Calculator.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,8 @@ public class Calculator {
1010
public Optional<Integer> sumAll(final Integer... valuesParam) {
1111
if (valuesParam == null) {
1212
return Optional.empty();
13-
} else if (valuesParam.length < 1) {
14-
return Optional.of(0);
15-
} else {
16-
return Optional.of(Arrays.stream(valuesParam)
17-
.reduce(0, (a, b) -> a + b));
1813
}
14+
15+
return Optional.of(Arrays.stream(valuesParam).reduce(0, Integer::sum));
1916
}
2017
}

src/main/java/se/cygni/palmithor/tdd/StringUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ public class StringUtils {
44

55

66
public boolean isPalindrome(final String str) {
7-
throw new RuntimeException("Not yet implemented");
7+
return str != null && str.equals(new StringBuilder(str).reverse().toString());
88
}
99

1010

@@ -15,6 +15,6 @@ public boolean isPalindrome(final String str) {
1515
* @return true if str is null, empty or whitespace only, otherwise false
1616
*/
1717
public boolean isBlank(final String str) {
18-
throw new RuntimeException("Not yet implemented");
18+
return str == null || str.trim().isEmpty();
1919
}
2020
}

src/test/java/se/cygni/palmithor/tdd/CalculatorTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ public class CalculatorTest {
1313

1414
@Test
1515
public void test() {
16-
assertThat(calculator.sumAll().get()).isEqualTo(1); // TODO failing on purpose please fix
16+
assertThat(calculator.sumAll()).isEqualTo(Optional.of(0));
17+
assertThat(calculator.sumAll(null)).isEqualTo(Optional.empty());
1718
}
1819

1920

src/test/java/se/cygni/palmithor/tdd/StringUtilsTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ public void isPalindrome() {
2424
*/
2525
@Test
2626
public void isBlank() {
27-
// stringUtils.isBlank()
27+
28+
assertThat(stringUtils.isBlank("")).isTrue();
29+
assertThat(stringUtils.isBlank(" ")).isTrue();
30+
assertThat(stringUtils.isBlank(null)).isTrue();
31+
32+
assertThat(stringUtils.isBlank("hej")).isFalse();
2833
}
2934
}

0 commit comments

Comments
 (0)