fix: add deterministic ordering to history queries and fix revert test

Add id DESC tiebreaker to all ORDER BY time queries with LIMIT
to ensure consistent results after MyISAM to InnoDB migration.
Fix BikeLastUsageTest to assert revert code matches the current
rent code, not the previous one.

Author: Volodymyr Panivko

src/Repository/HistoryRepository.php

@@ -104,7 +104,7 @@ public function findLastBikeRentByUser(int $bikeNumber, int $userId): ?array
             WHERE bikeNum = :bikeNumber
               AND userId = :userId
               AND action = :rentAction
-            ORDER BY time DESC
+            ORDER BY time DESC, id DESC
             LIMIT 1",
             [
                 'bikeNumber' => $bikeNumber,
@@ -149,7 +149,7 @@ public function findConfirmationRequest(string $checkCode, int $userId): ?array
             WHERE action = :phoneConfirmRequestAction
               AND parameter = :checkCode
               AND userId = :userId
-            ORDER BY time DESC
+            ORDER BY time DESC, id DESC
             LIMIT 1",
             [
                 'checkCode' => $checkCode,
@@ -263,7 +263,7 @@ public function findLastReturnStand(int $bikeNum): ?array
              LEFT JOIN history ON stands.standId = parameter
              WHERE bikeNum = :bikeNum
                AND action IN (:returnAction, :forceReturnAction)
-             ORDER BY time DESC
+             ORDER BY time DESC, history.id DESC
              LIMIT 1",
             [
                 'bikeNum' => $bikeNum,
@@ -291,7 +291,7 @@ public function findLastRentCode(int $bikeNum): ?string
              FROM history
              WHERE bikeNum = :bikeNum
                AND action IN (:rentAction, :forceRentAction)
-             ORDER BY time DESC
+             ORDER BY time DESC, id DESC
              LIMIT 1",
             [
                 'bikeNum' => $bikeNum,
@@ -352,17 +352,17 @@ public function findUserTripHistory(int $userId, int $limit = 10): array
               (SELECT r.time FROM history r
                WHERE r.userId = h.userId AND r.bikeNum = h.bikeNum
                  AND r.action IN (:returnAction, :forceReturnAction) AND r.time >= h.time
-               ORDER BY r.time ASC LIMIT 1) AS returnTime,
+               ORDER BY r.time ASC, r.id ASC LIMIT 1) AS returnTime,
               (SELECT s.standName FROM history r
                LEFT JOIN stands s ON s.standId = r.parameter
                WHERE r.userId = h.userId AND r.bikeNum = h.bikeNum
                  AND r.action IN (:returnAction2, :forceReturnAction2) AND r.time >= h.time
-               ORDER BY r.time ASC LIMIT 1) AS standName,
+               ORDER BY r.time ASC, r.id ASC LIMIT 1) AS standName,
               (SELECT s2.standName FROM history r2
                LEFT JOIN stands s2 ON s2.standId = r2.parameter
                WHERE r2.bikeNum = h.bikeNum
                  AND r2.action IN (:returnAction3, :forceReturnAction3) AND r2.time < h.time
-               ORDER BY r2.time DESC LIMIT 1) AS fromStandName
+               ORDER BY r2.time DESC, r2.id DESC LIMIT 1) AS fromStandName
             FROM history h
             WHERE h.userId = :userId AND h.action IN (:rentAction, :forceRentAction)
             ORDER BY h.time DESC, h.id DESC

tests/Application/Controller/Api/Bike/BikeLastUsageTest.php

@@ -59,7 +59,7 @@ public function testTrip(): void
 
         $this->assertSame(
             $responseData['history'][2]['parameter'], //REVERT
-            $responseData['history'][5]['parameter'], //RENT
+            $responseData['history'][3]['parameter'], //RENT (the one being reverted)
             'Incorrect code after revert. Full history' . json_encode($responseData['history'])
         );
     }