Merge pull request #7013 from oliver-sanders/packaging-tests++

packaging: check pip/conda compatibility

Author: MetRonnie

.github/workflows/test_conda-build.yml

@@ -5,6 +5,8 @@ on:
     paths:
       - 'conda-environment.yml'
       - '.github/workflows/test_conda-build.yml'
+      - 'pyproject.toml'
+      - 'setup.cfg'
   schedule:
     - cron: '17 22 * * 6'  # Every Saturday at 22:17
   workflow_dispatch:
@@ -31,13 +33,16 @@ jobs:
         python-version: ['3.12', '3']
     env:
       ENV_FILE: conda-environment.yml
+      # prevent pip from meddling with the conda installed dependencies (during the conda build step)
+      PIP_NO_DEPS: True
     steps:
       - name: checkout cylc-flow
         uses: actions/checkout@v5
 
       - name: modify conda env file
         run: |
           # write environment file
+          echo "  - python = ${{ matrix.python-version }}" >> "$ENV_FILE"
           echo "  - pip"  >> "$ENV_FILE"  # list pip as a dependency
           echo "  - pip:" >> "$ENV_FILE"  # add a pip section
           echo "    - ."  >> "$ENV_FILE"  # install cylc-flow (pip install .)
@@ -46,14 +51,18 @@ jobs:
       - name: build conda env
         uses: conda-incubator/setup-miniconda@v3
         with:
-          python-version: ${{ matrix.python-version }}
           environment-file: ${{ env.ENV_FILE }}
 
       - name: check cylc installation
         shell: bash -el {0}
         run: |
+          # make sure Cylc is functioning
           conda run -n test cylc version --long
 
+          # make sure pip is happy with the packages installed
+          # (checks pip deps are compatible with conda deps)
+          conda run -n test pip check
+
       - name: check for activate scripts
         shell : bash -el {0}
         run: |

conda-environment.yml

@@ -12,7 +12,7 @@ dependencies:
   - metomi-isodatetime >=1!3.0.0, <1!3.2.0
   - packaging
   # Constrain protobuf version for compatible Scheduler-UIS comms across hosts
-  - protobuf >=4.24.4,<4.25.0
+  - protobuf >=5,<8
   - psutil >=5.6.0
   - python
   - pyzmq >=22