Add test for cylc reinstall with permissions changed

Author: MetRonnie

tests/integration/test_reinstall.py

@@ -19,28 +19,23 @@
 import asyncio
 from contextlib import asynccontextmanager
 from pathlib import Path
+from secrets import token_hex
 from types import SimpleNamespace
-from uuid import uuid1
 
 import pytest
 
-from cylc.flow.exceptions import (
-    WorkflowFilesError,
-)
-from cylc.flow.install import (
-    reinstall_workflow,
-)
+from cylc.flow.exceptions import WorkflowFilesError
+from cylc.flow.install import reinstall_workflow
 from cylc.flow.option_parsers import Options
 from cylc.flow.scripts.reinstall import (
     get_option_parser as reinstall_gop,
     reinstall_cli,
 )
-from cylc.flow.workflow_files import (
-    WorkflowFiles,
-)
+from cylc.flow.workflow_files import WorkflowFiles
 
 from .utils.entry_points import EntryPointWrapper
 
+
 ReInstallOptions = Options(reinstall_gop())
 
 # cli opts
@@ -77,7 +72,7 @@ def one_src(tmp_path):
 
 @pytest.fixture
 def one_run(one_src, test_dir, run_dir):
-    w_run_dir = test_dir / str(uuid1())
+    w_run_dir = test_dir / token_hex(4)
     w_run_dir.mkdir()
     (w_run_dir / 'flow.cylc').touch()
     (w_run_dir / 'rose-suite.conf').touch()
@@ -303,6 +298,35 @@ async def test_rsync_fail(one_src, one_run, mock_glbl_cfg, non_interactive):
     assert 'An error occurred reinstalling' in str(exc_ctx.value)
 
 
+async def test_permissions_change(
+    one_src,
+    one_run,
+    interactive,
+    monkeypatch: pytest.MonkeyPatch,
+    capsys: pytest.CaptureFixture,
+):
+    """It detects permissions changes."""
+    # Add script file:
+    script_path: Path = one_src.path / 'myscript'
+    script_path.touch()
+    await reinstall_cli(
+        opts=ReInstallOptions(skip_interactive=True), workflow_id=one_run.id
+    )
+    assert (one_run.path / 'myscript').is_file()
+    capsys.readouterr()  # clears capsys
+
+    # Change permissions (e.g. user forgot to make it executable before)
+    script_path.chmod(0o777)
+    # Answer "no" to reinstall prompt (we just want to test dry run)
+    monkeypatch.setattr('cylc.flow.scripts.reinstall._input', lambda x: 'n')
+    monkeypatch.setattr('cylc.flow.flags.verbosity', 1)
+    await reinstall_cli(
+        opts=ReInstallOptions(), workflow_id=one_run.id
+    )
+    out, _ = capsys.readouterr()
+    assert "send myscript" in out
+
+
 @pytest.fixture
 def my_install_plugin(monkeypatch):
     """This configures a single post_install plugin.