Merge pull request #7022 from MetRonnie/logging

Demote logging of "LOADING task run times" & "action timers" to debug

Author: hjoliver

cylc/flow/scheduler.py

@@ -945,15 +945,15 @@ def manage_remote_init(self):
     def _load_task_run_times(self, row_idx, row):
         """Load run times of previously succeeded task jobs."""
         if row_idx == 0:
-            LOG.info("LOADING task run times")
+            LOG.debug("LOADING task run times")
         name, run_times_str = row
         try:
             taskdef = self.config.taskdefs[name]
             maxlen = TaskDef.MAX_LEN_ELAPSED_TIMES
             for run_time_str in run_times_str.rsplit(",", maxlen)[-maxlen:]:
                 run_time = int(run_time_str)
                 taskdef.elapsed_times.append(run_time)
-            LOG.info("+ %s: %s" % (
+            LOG.debug("+ %s: %s" % (
                 name, ",".join(str(s) for s in taskdef.elapsed_times)))
         except (KeyError, ValueError, AttributeError):
             return

cylc/flow/task_pool.py

@@ -664,7 +664,7 @@ def load_db_task_pool_for_restart(self, row_idx, row):
     def load_db_task_action_timers(self, row_idx: int, row: Iterable) -> None:
         """Load a task action timer, e.g. event handlers, retry states."""
         if row_idx == 0:
-            LOG.info("LOADING task action timers")
+            LOG.debug("LOADING task action timers")
         (cycle, name, ctx_key_raw, ctx_raw, delays_raw, num, delay,
          timeout) = row
         tokens = Tokens(
@@ -701,7 +701,7 @@ def load_db_task_action_timers(self, row_idx: int, row: Iterable) -> None:
                 "%(id)s: skip action timer %(ctx_key)s" %
                 {"id": id_, "ctx_key": ctx_key_raw})
             return
-        LOG.info("+ %s/%s %s" % (cycle, name, ctx_key))
+        LOG.debug("+ %s/%s %s" % (cycle, name, ctx_key))
         if ctx_key == "poll_timer":
             itask = self._get_task_by_id(id_)
             if itask is None:
@@ -721,7 +721,7 @@ def load_db_task_action_timers(self, row_idx: int, row: Iterable) -> None:
                     ctx_key[1] = TimerFlags.EXECUTION_RETRY
 
                 if timeout:
-                    LOG.info(
+                    LOG.debug(
                         f'  (upgrading retrying state for {itask.identity})')
                     self.task_events_mgr._retry_task(
                         itask,

tests/flakyfunctional/restart/21-task-elapsed.t

@@ -45,7 +45,7 @@ workflow_run_ok "${TEST_NAME_BASE}-run" \
     cylc play "${WORKFLOW_NAME}" --debug --no-detach --stopcp=2020
 workflow_run_ok "${TEST_NAME_BASE}-restart-1" \
     cylc play "${WORKFLOW_NAME}" --stopcp=2028 --debug --no-detach
-sed -n '/LOADING task run times/,+2{s/^.* INFO - //;s/[0-9]\(,\|$\)/%d\1/g;p}' \
+sed -n '/LOADING task run times/,+2{s/^.* DEBUG - //;s/[0-9]\(,\|$\)/%d\1/g;p}' \
     "${RUND}/log/scheduler/log" >'restart-1.out'
 contains_ok "restart-1.out" <<'__OUT__'
 LOADING task run times
@@ -54,7 +54,7 @@ LOADING task run times
 __OUT__
 workflow_run_ok "${TEST_NAME_BASE}-restart-2" \
     cylc play "${WORKFLOW_NAME}" --stopcp=2030 --debug --no-detach
-sed -n '/LOADING task run times/,+2{s/^.* INFO - //;s/[0-9]\(,\|$\)/%d\1/g;p}' \
+sed -n '/LOADING task run times/,+2{s/^.* DEBUG - //;s/[0-9]\(,\|$\)/%d\1/g;p}' \
     "${RUND}/log/scheduler/log" >'restart-2.out'
 contains_ok 'restart-2.out' <<'__OUT__'
 LOADING task run times