chore: Ensure exported dm functions call check_dm() first (#2442)

Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Author: Copilot

R/dm_wrap.R

@@ -41,6 +41,7 @@
 #'   dm_wrap_tbl(root = airlines)
 dm_wrap_tbl <- function(dm, root, strict = TRUE, progress = NA) {
   dm_local_error_call()
+  check_dm(dm)
 
   wrap_plan <- dm_wrap_tbl_plan(dm, {{ root }})
 

R/draw-dm.R

@@ -355,6 +355,7 @@ dm_get_all_column_types <- function(x) {
 #' @autoglobal
 dm_set_colors <- function(dm, ...) {
   dm_local_error_call()
+  check_dm(dm)
   quos <- enquos(...)
   if (any(names(quos) == "")) {
     abort_only_named_args("dm_set_colors", "the colors")
@@ -414,6 +415,8 @@ color_quos_to_display <- function(...) {
 #' @rdname dm_set_colors
 #' @export
 dm_get_colors <- function(dm) {
+  dm_local_error_call()
+  check_dm(dm)
   dm %>%
     dm_get_def() %>%
     select(table, display) %>%

R/zoom.R

@@ -217,6 +217,7 @@ dm_update_zoomed <- function(dm) {
 #' @autoglobal
 dm_discard_zoomed <- function(dm) {
   dm_local_error_call()
+  check_dm(dm)
   if (!is_zoomed(dm)) {
     return(dm)
   }

tests/testthat/_snaps/error-ownership.md

@@ -102,6 +102,38 @@
       Error in `check_cardinality_0_1()`:
       ! 0..1 cardinality (injectivity from child table to parent table) is not given: Column (`x`) in table child contains duplicate values.
 
+# dm_set_colors() - abort_is_not_dm
+
+    Code
+      dm_set_colors("not_a_dm", blue = a)
+    Condition
+      Error in `dm_set_colors()`:
+      ! Required class <dm> but instead is <character>.
+
+# dm_get_colors() - abort_is_not_dm
+
+    Code
+      dm_get_colors("not_a_dm")
+    Condition
+      Error in `dm_get_colors()`:
+      ! Required class <dm> but instead is <character>.
+
+# dm_discard_zoomed() - abort_is_not_dm
+
+    Code
+      dm_discard_zoomed("not_a_dm")
+    Condition
+      Error in `dm_discard_zoomed()`:
+      ! Required class <dm> but instead is <character>.
+
+# dm_wrap_tbl() - abort_is_not_dm
+
+    Code
+      dm_wrap_tbl("not_a_dm", root = a)
+    Condition
+      Error in `dm_wrap_tbl()`:
+      ! Required class <dm> but instead is <character>.
+
 # dm_set_colors() - abort_only_named_args
 
     Code

tests/testthat/test-error-ownership.R

@@ -123,6 +123,38 @@ test_that("check_cardinality_0_1() - abort_not_injective", {
   })
 })
 
+test_that("dm_set_colors() - abort_is_not_dm", {
+  local_options(lifecycle_verbosity = "quiet")
+
+  expect_snapshot(error = TRUE, {
+    dm_set_colors("not_a_dm", blue = a)
+  })
+})
+
+test_that("dm_get_colors() - abort_is_not_dm", {
+  local_options(lifecycle_verbosity = "quiet")
+
+  expect_snapshot(error = TRUE, {
+    dm_get_colors("not_a_dm")
+  })
+})
+
+test_that("dm_discard_zoomed() - abort_is_not_dm", {
+  local_options(lifecycle_verbosity = "quiet")
+
+  expect_snapshot(error = TRUE, {
+    dm_discard_zoomed("not_a_dm")
+  })
+})
+
+test_that("dm_wrap_tbl() - abort_is_not_dm", {
+  local_options(lifecycle_verbosity = "quiet")
+
+  expect_snapshot(error = TRUE, {
+    dm_wrap_tbl("not_a_dm", root = a)
+  })
+})
+
 test_that("dm_set_colors() - abort_only_named_args", {
   local_options(lifecycle_verbosity = "quiet")