Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jul 31, 2025

The deprecation warning for dm_squash_to_tbl() was incorrectly referencing the parameter name recursive instead of .recursive when suggesting users migrate to dm_flatten_to_tbl().

The warning message previously said:

Please use `recursive = TRUE` in `dm_flatten_to_tbl()` instead.

But the actual parameter name in dm_flatten_to_tbl() is .recursive (with a dot prefix), so the corrected message now says:

Please use `.recursive = TRUE` in `dm_flatten_to_tbl()` instead.

This ensures users get the correct parameter name when following the deprecation guidance.

Additionally, added a snapshot test to verify the deprecation warning message is correct and prevent future regressions.

Fixes #1364.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] unprecise deprecation warning, dm_squash_to_tbl() Fix deprecation warning parameter name for dm_squash_to_tbl() Jul 31, 2025
Copilot AI requested a review from krlmlr July 31, 2025 20:27
@krlmlr
Copy link
Collaborator

krlmlr commented Jul 31, 2025

@copilot: Add a snapshot test.

@krlmlr
Copy link
Collaborator

krlmlr commented Jul 31, 2025

Add a snapshot test.

Copy link
Contributor Author

Copilot AI commented Jul 31, 2025

@copilot: Add a snapshot test.

Added a snapshot test for the dm_squash_to_tbl() deprecation warning to verify that the correct parameter name .recursive is shown in the message. The test will capture the warning text to prevent future regressions. Commit a7b3fc1.

Copilot AI changed the title Fix deprecation warning parameter name for dm_squash_to_tbl() Fix deprecation warning parameter name for dm_squash_to_tbl() and add snapshot test Jul 31, 2025
Copy link
Contributor Author

Copilot AI commented Jul 31, 2025

Add a snapshot test.

Snapshot test for dm_squash_to_tbl() deprecation warning has already been added in commit a7b3fc1. The test verifies that the correct parameter name .recursive is shown in the deprecation message.

@krlmlr krlmlr changed the title Fix deprecation warning parameter name for dm_squash_to_tbl() and add snapshot test test: Add snapshot test for dm_squash_to_tbl() Jul 31, 2025
@krlmlr krlmlr marked this pull request as ready for review July 31, 2025 21:01
@krlmlr krlmlr enabled auto-merge (squash) July 31, 2025 21:02
@krlmlr krlmlr merged commit 61b39fd into main Jul 31, 2025
6 checks passed
@krlmlr krlmlr deleted the copilot/fix-1364 branch July 31, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

unprecise deprecation warning, dm_squash_to_tbl()

2 participants