-
Notifications
You must be signed in to change notification settings - Fork 49
test: Add snapshot test for dm_squash_to_tbl()
#2299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RUE' Co-authored-by: krlmlr <[email protected]>
Copilot
AI
changed the title
[WIP] unprecise deprecation warning, dm_squash_to_tbl()
Fix deprecation warning parameter name for dm_squash_to_tbl()
Jul 31, 2025
Collaborator
|
@copilot: Add a snapshot test. |
Collaborator
|
Add a snapshot test. |
Co-authored-by: krlmlr <[email protected]>
Contributor
Author
Copilot
AI
changed the title
Fix deprecation warning parameter name for dm_squash_to_tbl()
Fix deprecation warning parameter name for dm_squash_to_tbl() and add snapshot test
Jul 31, 2025
Contributor
Author
Snapshot test for dm_squash_to_tbl() deprecation warning has already been added in commit a7b3fc1. The test verifies that the correct parameter name |
dm_squash_to_tbl()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation warning for
dm_squash_to_tbl()was incorrectly referencing the parameter namerecursiveinstead of.recursivewhen suggesting users migrate todm_flatten_to_tbl().The warning message previously said:
But the actual parameter name in
dm_flatten_to_tbl()is.recursive(with a dot prefix), so the corrected message now says:This ensures users get the correct parameter name when following the deprecation guidance.
Additionally, added a snapshot test to verify the deprecation warning message is correct and prevent future regressions.
Fixes #1364.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.