misc: display AUT bar in dark mode #31360
Conversation
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
aut-dark-mode
|
| Run status |
|
| Run duration | 18m 41s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
10
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32133
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.59%
|
|
|---|---|
|
Untested elements
|
183
|
|
Tested elements
|
164
|
Accessibility
92.63%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
881
|
| cy.startAppServer(testingType) | ||
| cy.visitApp() | ||
| cy.specsPageIsVisible() | ||
| describe('dragging panels', () => { |
There was a problem hiding this comment.
I split these tests out because...these tests are bonkers. It seems like it was originally testing the AUT scale %, but then had a bunch of UI assertions just tacked onto it.
Additionally, I removed a test around testing the 200 reporter width at a 500 width screen. The UI is so smooshed, it's a bit ridiculous to even test the UI at that size.
| @@ -23,7 +23,7 @@ | |||
| "dependencies": {}, | |||
| "devDependencies": { | |||
| "@cypress-design/icon-registry": "^1.5.1", | |||
| "@cypress-design/vue-button": "^1.1.0", | |||
| "@cypress-design/vue-button": "^1.3.0", | |||
There was a problem hiding this comment.
We're actually not even using this component in the AUT, so this update doesn't do anything.
| @@ -182,26 +160,20 @@ describe('SelectorPlayground', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| // TODO: fix this flaky test | |||
| it.skip('shows tooltips when buttons are focused', () => { | |||
| it('shows copy tooltip when button is focused', () => { | |||
There was a problem hiding this comment.
Split these tests up. I think they're flaky because it's trying to do one tooltip after another which just doesn't work well with our tooltip components.
|
This Percy snapshot is just not accurate btw. I ran this locally and it doesn't do this. I think it may be a percy glitch. |
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
Update AUT bar to be dark mode - according to Figma
I did not actually end up getting rid of the Selector Playground active button and moving the state into the AUT bar. This is a bit more complex of a change than I want to spend time on since this will likely be removed with Studio enhancements anyway.
Steps to test
yarnpackages/apprunyarn cypress:run:e2e --no-exit --headed --spec=cypress/e2e/runner/cloud-debug-filter.cy.ts --browser=chromepackages/apprunyarn cypress:openand choose an end-to-end and ct test to view.How has the user experience changed?
Before
Run mode
Open mode
Selector Playground expanded
Selector Playground invalid
Tooltip
Selector Dropdown
Browser Dropdown
CT Testing
After
Run mode
Open mode
Selector Playground expanded
Selector Playground invalid
Tooltip
Selector Dropdown
Browser Dropdown
CT Testing
PR Tasks
cypress-documentation?type definitions?