Added support for Identifier values

Author: mastrzyz

lib/rules/no-unnecessary-waiting.js

@@ -21,8 +21,12 @@ module.exports = {
   create (context) {
     return {
       CallExpression (node) {
-        if (isCallingCyWait(node) && isNumberArgument(node)) {
-          context.report({ node, messageId: 'unexpected' })
+        if (isCallingCyWait(node)) {
+          const scope = context.getScope()
+
+          if (isIdentifierNumberConstArgument(node, scope) || isNumberArgument(node)) {
+            context.report({ node, messageId: 'unexpected' })
+          }
         }
       },
     }
@@ -42,3 +46,14 @@ function isNumberArgument (node) {
          node.arguments[0].type === 'Literal' &&
          typeof (node.arguments[0].value) === 'number'
 }
+
+function isIdentifierNumberConstArgument (node, scope) {
+  if (node.arguments[0].type !== 'Identifier') {
+    return false
+  }
+
+  const resolvedIdentifier = scope.resolve(node.arguments[0]).resolved
+  const IdentifierValue = resolvedIdentifier.defs[0].node.init.value
+
+  return typeof IdentifierValue === 'number'
+}