Skip to content

Commit 6d4f8f5

Browse files
authored
feat(deps): remove node.js 18 (#1446)
1 parent 831a51d commit 6d4f8f5

File tree

2 files changed

+6
-15
lines changed

2 files changed

+6
-15
lines changed

.github/workflows/example-node-versions.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
node: [18, 20, 22, 23]
16+
node: [20, 22, 23]
1717
name: Cypress E2E on Node v${{ matrix.node }}
1818
steps:
1919
- name: Setup Node

README.md

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ The following examples demonstrate the actions' functions.
5454
- [Start server](#start-server) before running the tests
5555
- [Start multiple servers](#start-multiple-servers) before running the tests
5656
- [Wait for server](#wait-on) to respond before running the tests
57-
- [`wait-on` with Node.js 18+](#wait-on-with-nodejs-18) workarounds
5857
- Use [custom install command](#custom-install-command)
5958
- Use [command prefix](#command-prefix)
6059
- Use [own custom test command](#custom-test-command)
@@ -529,7 +528,7 @@ jobs:
529528
# let's make sure our "app" works on several versions of Node
530529
strategy:
531530
matrix:
532-
node: [18, 20, 22, 23]
531+
node: [20, 22, 23]
533532
name: E2E on Node v${{ matrix.node }}
534533
steps:
535534
- name: Setup Node
@@ -555,7 +554,7 @@ The recording will have tags as labels on the run.
555554

556555
![Tags](images/tags.png)
557556

558-
You can pass multiple tags using commas like `tag: node-18,nightly,staging`.
557+
You can pass multiple tags using commas like `tag: node-22,nightly,staging`.
559558

560559
### Auto cancel after failures
561560

@@ -916,14 +915,6 @@ See [example-wait-on.yml](.github/workflows/example-wait-on.yml) workflow file.
916915

917916
If this action times out waiting for the server to respond, please see [Debugging](#debugging) section in this README file.
918917

919-
#### `wait-on` with Node.js 18+
920-
921-
Under Node.js version 18 and later, `wait-on` may fail to recognize that a `localhost` server is running. This affects development web servers which do not listen on both IPv4 and IPv6 network stacks.
922-
923-
- Check your server documentation to see if it can be started using `0.0.0.0` (all addresses) and use this if available. If this option is not available or does not resolve the issue then carry on to the next steps:
924-
- If the action log shows that `wait-on` is failing to connect to `127.0.0.1`, replace `localhost` by `[::1]` (the IPv6 loopback address)
925-
- If the action log shows that `wait-on` is failing to connect to `::1`, replace `localhost` by `127.0.0.1` (the IPv4 loopback address)
926-
927918
### Custom install command
928919

929920
The action installs dependencies based on a package manager lock file using default commands described in the [Installation](#installation) section below. If you want to overwrite the default install command you can use the `install-command` option:
@@ -1302,7 +1293,7 @@ jobs:
13021293
# let's make sure our "app" works on several versions of Node
13031294
strategy:
13041295
matrix:
1305-
node: [18, 20, 22, 23]
1296+
node: [20, 22, 23]
13061297
name: E2E on Node v${{ matrix.node }}
13071298
steps:
13081299
- name: Setup Node
@@ -1336,7 +1327,7 @@ jobs:
13361327
runs-on: ubuntu-24.04
13371328
strategy:
13381329
matrix:
1339-
node: [18, 20, 22, 23]
1330+
node: [20, 22, 23]
13401331
name: E2E on Node v${{ matrix.node }}
13411332
steps:
13421333
- uses: actions/setup-node@v4
@@ -1758,7 +1749,7 @@ jobs:
17581749

17591750
Node.js is required to run this action. The recommended version `v6` supports:
17601751

1761-
- **Node.js** 18.x, 20.x, 22.x and 23.x
1752+
- **Node.js** 20.x, 22.x and 23.x
17621753

17631754
and is generally aligned with [Node.js's release schedule](https://github.com/nodejs/Release).
17641755

0 commit comments

Comments
 (0)