-
Notifications
You must be signed in to change notification settings - Fork 360
Description
Situation
The renovate.json configuration controls how dependencies are updated by Renovate (see Renovate configuration overview).
Although Renovate is set to automerge, this is not effective and all Renovate PRs wait for manual approval.
Lines 6 to 9 in 945856d
| "automerge": true, | |
| "major": { | |
| "automerge": false | |
| }, |
The Renovate documentation discusses this restriction under Required Pull Request reviews, although the advice may be outdated, as GitHub now offers rulesets in addition to classic branch protection rules.
Suggestion
The Cypress.io team should investigate if the advice to allow Renovate automerge can be implemented:
If you're on github.com or GitHub Enterprise Server (>=3.4) you can let Renovate bypass the mandatory Pull Request reviews using the "Allow specified actors to bypass required pull requests" option in your branch protection rules.
Note that the link Allow specified actors to bypass required pull requests concerns a GitHub blog post from Nov 2021 which describes the use of classic branch protections rules:
Optionally, to allow specific actors to push code to the branch without creating pull requests when they're required, select Allow specified actors to bypass required pull requests. Then, search for and select the actors who should be allowed to skip creating a pull request.
In the meantime GitHub now offers rulesets including the ability to bypass.
This repo currently has no rulesets defined. See https://github.com/cypress-io/github-action/rules