Add support for routines in postgresql_default_privileges #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas D. Spear <[email protected]>
|
Would be great to get this one in! |
|
@tspearconquest Thanks for your work on that. There was an issue with your changes, it was enough to allow the provider to apply the privileges but then it was failing while trying to read privileges. I pushed a small fix and an associated acceptance test to assert that it works properly. |
cyrilgdn
approved these changes
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds some support for routines in the
postgresql_default_privilegesresource.I hope it is satisfactory. Go is not my strength, so please let me know if it is insufficient as I will retract this PR in that case.
Related: #470