Allow configuring maximum idle connections#608
Conversation
|
@jBouyoud Could you rebase your PR on main please (I can't do it with the UI, you probably didn't allow update by maintainer) so I can trigger the tests |
There was a problem hiding this comment.
Pull request overview
This PR adds a new provider configuration option to control the PostgreSQL connection pool’s maximum idle connections, wiring it from Terraform schema into the internal client configuration and documenting the new argument.
Changes:
- Added a
max_idle_connectionsprovider argument and plumbed it into the provider configuration. - Extended the internal
Configto carry the idle-connection limit and applied it viadb.SetMaxIdleConns(...). - Updated website documentation to describe the new setting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
website/docs/index.html.markdown |
Documents the new max_idle_connections provider argument and its default/semantics. |
postgresql/provider.go |
Adds the new schema field and passes it into the provider Config during configuration. |
postgresql/config.go |
Adds the new Config field and applies it to the *sql.DB pool via SetMaxIdleConns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * `max_idle_connections` - (Optional) Maximum number of idle connections. | ||
| Zero means no idle connections, useful when Db is managed in the same terraform state. The default is `0`. |
| Description: "Maximum number of idle connections. Zero means no idle connections, useful when Db is managed in the same terraform state.", | ||
| ValidateFunc: validation.IntAtLeast(-1), |
| MaxConns int | ||
| MaxIDleConns int | ||
| ExpectedVersion semver.Version |
| db.SetMaxIdleConns(c.config.MaxIDleConns) | ||
| db.SetMaxOpenConns(c.config.MaxConns) |
| ConnectTimeoutSec: d.Get("connect_timeout").(int), | ||
| MaxConns: d.Get("max_connections").(int), | ||
| MaxIDleConns: d.Get("max_idle_connections").(int), | ||
| ExpectedVersion: version, |
| ConnectTimeoutSec: d.Get("connect_timeout").(int), | ||
| MaxConns: d.Get("max_connections").(int), | ||
| MaxIDleConns: d.Get("max_idle_connections").(int), | ||
| ExpectedVersion: version, |
|
Hi @cyrilgdn 👋 I've rebased this PR onto the latest |
This PR adds support for configuring the maximum number of idle connections in the PostgreSQL connection pool.
Changes
MaxIDleConnsfield to theConfigstructSetMaxIdleConnson the database connection using the new parameterContext
This enhancement provides more flexibility in managing database connections, particularly useful for optimizing performance in huge ressources contexts