Skip to content

Refactor convert.py with greater modularity #430

@d33bs

Description

@d33bs

I agree with @gwaybio's comment that convert.py is getting long and it's a little difficult to focus on the parts that matter, but since this PR touches very little of that code I'd refrain from doing that refactor here.

For when you do refactor it, I'd prefer to see the utility functions moved out to different modules, but I'm unsure if that would complicate things with how parsl ships out modules to its workers. You might be able to get away with reordering things in the convert module, i.e. moving convert() up nearer to the top of the file; Python doesn't require that all functions called within a function are defined when it's defined, just that they're available when the function is called.

Originally posted by @falquaddoomi with references to comments by @gwaybio in #424 (review)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions