Skip to content

Commit b0914c2

Browse files
authored
Merge pull request #71 from slr71/main
Fix a schema validation error for group deletion requests.
2 parents fe33ae6 + 76fed04 commit b0914c2

File tree

3 files changed

+16
-9
lines changed

3 files changed

+16
-9
lines changed

skaffold.yaml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
1-
apiVersion: skaffold/v1
1+
apiVersion: skaffold/v3
22
kind: Config
33
metadata:
44
name: data-info
5-
deploy:
6-
kubectl:
7-
manifests:
8-
- k8s/data-info.yml
95
build:
6+
artifacts:
7+
- image: harbor.cyverse.org/de/data-info
108
tagPolicy:
119
gitCommit: {}
12-
artifacts:
13-
- image: harbor.cyverse.org/de/data-info
1410
local: {}
11+
platforms:
12+
- "linux/amd64"
13+
manifests:
14+
rawYaml:
15+
- k8s/data-info.yml
16+
deploy:
17+
kubectl: {}

src/data_info/routes/groups.clj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@
4141
(assoc GroupErrorResponses
4242
:error_code DeleteErrorCodes))
4343

44+
(s/defschema GroupDeleted
45+
{:name (describe String "group name")})
46+
4447
(defroutes groups-routes
4548
(context "/groups" []
4649
:tags ["groups"]
@@ -94,7 +97,8 @@
9497
:description data-schema/CommonErrorCodeDocs}}
9598
{403 {:schema ErrorResponseForbidden
9699
:description "No access to group administration"}}
97-
{200 {:description "Successful response"}})
100+
{200 {:schema GroupDeleted
101+
:description "Successful response"}})
98102
:summary "Delete group"
99103
:description "Delete an IRODS group's members"
100104
(ok (groups/delete-group params group-name))))))

src/data_info/services/groups.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,4 @@
5959
(validators/user-is-group-admin cm user)
6060
(when (users/group-exists? cm group-name)
6161
(users/delete-user-group cm group-name))
62-
nil))
62+
{:name group-name}))

0 commit comments

Comments
 (0)