Skip to content

Commit f690841

Browse files
committed
CORE-2055: fixed some deprecation warnings; this introduces a breaking change
1 parent f46c794 commit f690841

File tree

2 files changed

+23
-11
lines changed

2 files changed

+23
-11
lines changed

amqp.go

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,13 +301,21 @@ func (c *Client) CreateQueue(name, exchange, key string, durable, autoDelete boo
301301

302302
// QueueExists returns true if the given queue name exists, false or an error
303303
// otherwise.
304-
func (c *Client) QueueExists(name string) (bool, error) {
304+
func (c *Client) QueueExists(name string, durable, autoDelete bool) (bool, error) {
305305
channel, err := c.connection.Channel()
306306
if err != nil {
307307
return false, err
308308
}
309309
defer channel.Close()
310-
if _, err = channel.QueueInspect(name); err != nil {
310+
_, err = channel.QueueDeclarePassive(
311+
name,
312+
durable,
313+
autoDelete,
314+
false, // internal
315+
false, // no wait
316+
nil, // args
317+
)
318+
if err != nil {
311319
if strings.Contains(err.Error(), "404") {
312320
return false, nil
313321
}

amqp_test.go

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,11 @@ func shouldrun() bool {
3535
}
3636

3737
func uri() string {
38-
return "amqp://guest:guest@rabbit:5672/%2fde"
38+
uri := os.Getenv("INTEGRATION_TEST_AMQP_URI")
39+
if uri == "" {
40+
uri = "amqp://guest:guest@rabbit:5672/%2fde"
41+
}
42+
return uri
3943
}
4044

4145
func exchange() string {
@@ -349,7 +353,7 @@ func TestCreateQueue(t *testing.T) {
349353
if actual == nil {
350354
t.Error("channel is nil")
351355
}
352-
if _, err = actual.QueueInspect("test_queue5"); err != nil {
356+
if _, err = actual.QueueDeclarePassive("test_queue5", true, false, false, false, nil); err != nil {
353357
t.Error(err)
354358
}
355359
if err = actual.Close(); err != nil {
@@ -369,7 +373,7 @@ func TestQueueExists(t *testing.T) {
369373
if actual == nil {
370374
t.Error("channel is nil")
371375
}
372-
exists, err := client.QueueExists("test_queue5")
376+
exists, err := client.QueueExists("test_queue5", true, false)
373377
if err != nil {
374378
t.Error(err)
375379
}
@@ -393,7 +397,7 @@ func TestDeleteQueue(t *testing.T) {
393397
if actual == nil {
394398
t.Error("channel is nil")
395399
}
396-
exists, err := client.QueueExists("test_queue6")
400+
exists, err := client.QueueExists("test_queue6", true, false)
397401
if err != nil {
398402
t.Error(err)
399403
}
@@ -408,7 +412,7 @@ func TestDeleteQueue(t *testing.T) {
408412
if actual == nil {
409413
t.Error("channel is nil")
410414
}
411-
exists, err = client.QueueExists("test_queue7")
415+
exists, err = client.QueueExists("test_queue7", true, false)
412416
if err != nil {
413417
t.Error(err)
414418
}
@@ -423,7 +427,7 @@ func TestDeleteQueue(t *testing.T) {
423427
if actual == nil {
424428
t.Error("channel is nil")
425429
}
426-
exists, err = client.QueueExists("test_queue8")
430+
exists, err = client.QueueExists("test_queue8", true, false)
427431
if err != nil {
428432
t.Error(err)
429433
}
@@ -434,7 +438,7 @@ func TestDeleteQueue(t *testing.T) {
434438
if err = client.DeleteQueue("test_queue6"); err != nil {
435439
t.Error(err)
436440
}
437-
exists, err = client.QueueExists("test_queue6")
441+
exists, err = client.QueueExists("test_queue6", true, false)
438442
if err != nil {
439443
t.Error(err)
440444
}
@@ -445,7 +449,7 @@ func TestDeleteQueue(t *testing.T) {
445449
if err = client.DeleteQueue("test_queue7"); err != nil {
446450
t.Error(err)
447451
}
448-
exists, err = client.QueueExists("test_queue7")
452+
exists, err = client.QueueExists("test_queue7", true, false)
449453
if err != nil {
450454
t.Error(err)
451455
}
@@ -456,7 +460,7 @@ func TestDeleteQueue(t *testing.T) {
456460
if err = client.DeleteQueue("test_queue8"); err != nil {
457461
t.Error(err)
458462
}
459-
exists, err = client.QueueExists("test_queue8")
463+
exists, err = client.QueueExists("test_queue8", true, false)
460464
if err != nil {
461465
t.Error(err)
462466
}

0 commit comments

Comments
 (0)