[Question] Would it make sense to also wrap error responses in a Request::Response?

[F-3r]

The main objective would be to have a consistent interface for managing success responses and Error responses.

I find Requests::Response interface cleaner than Net::HTTP error responses (EG, response.to_hash to get the response headers is not very communicative nor intuitive, I almost always need to go back to Net:HTTP docs, which are not very communicative either :P)

I think having this consistency can make client code less surprising and might allow a more fluent dev experience.

[F-3r]

I was taking a look to the code, perhaps the cleanest way to do this backward-compatible is to make Error polymorphic with Response. That way you could do something like:

begin
  Requests.post('http://httpbin.org/something')
rescue Requests::Error => e
  assert_equal 404, e.status
  assert_equal Hash, e.headers.class
  assert_equal String, e.body.class
end