Skip to content

Commit 15319e5

Browse files
changed limit from min pressure to total vacuum pressure
1 parent dd150b9 commit 15319e5

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

ulc_mm_package/hardware/real/pneumatic_module.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,7 @@ def __init__(
260260
self.mprls_pwr_pin = mprls_pwr_pin
261261
self.prev_poll_time_s: float = 0.0
262262
self.prev_pressure: float = 0.0
263+
self.ambient_pressure: float = 0.0
263264
self.prev_status = PressureSensorRead.ALL_GOOD
264265

265266
self.io_error_counter = 0

ulc_mm_package/hardware/scope_routines.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,6 +411,8 @@ def checkPressureDifference(
411411
raise
412412

413413
# Check if there is a pressure leak
414+
mscope.pneumatic_module.mpr.ambient_pressure = ambient_pressure
415+
mscope.pneumatic_module.mpr.final_pressure = final_pressure
414416
pressure_diff = ambient_pressure - final_pressure
415417
if pressure_diff < MIN_PRESSURE_DIFF:
416418
raise PressureLeak(

ulc_mm_package/image_processing/flow_control.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33

44
import numpy as np
55

6-
from ulc_mm_package.scope_constants import CAMERA_SELECTION, DOWNSAMPLE_FACTOR, MIN_PRESSURE
6+
from ulc_mm_package.scope_constants import CAMERA_SELECTION, DOWNSAMPLE_FACTOR
77
from ulc_mm_package.image_processing.ewma_filtering_utils import EWMAFiltering
88
from ulc_mm_package.image_processing.processing_constants import (
99
FLOW_CONTROL_EWMA_ALPHA,
1010
TOL_PERC,
11+
MAX_VACUUM_PRESSURE,
1112
)
1213
from ulc_mm_package.image_processing.flowrate import FlowRateEstimator
1314

@@ -221,7 +222,7 @@ def _adjustSyringe(self, flow_error: float):
221222
try:
222223
# Increase pressure, move syringe down
223224
pressure, pressure_read = self.pneumatic_module.getPressure()
224-
if not self.pneumatic_module.is_locked() and pressure > MIN_PRESSURE:
225+
if not self.pneumatic_module.is_locked() and pressure > (self.pneumatic_module.mpr.ambient_pressure - MAX_VACUUM_PRESSURE):
225226
self.pneumatic_module.threadedDecreaseDutyCycle()
226227
except SyringeEndOfTravel:
227228
raise CantReachTargetFlowrate(self.flowrate)

ulc_mm_package/image_processing/processing_constants.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class FLOWRATE(enum.Enum):
3232
FLOW_CONTROL_EWMA_ALPHA = 0.05
3333
TOL_PERC = 0.1
3434
FAILED_CORR_PERC_TOLERANCE = 0.75
35-
MIN_PRESSURE = 650
35+
MAX_VACUUM_PRESSURE = 400 # mBar
3636

3737
# Factor by which to multiply the ewma feebdack adjustment delay (in frames) to set the window size
3838
# of the past measurements to check for failed xcorrs.

0 commit comments

Comments
 (0)