Get dict values correctly

mwlkhoo · mwlkhoo · commit b1355a784e0e · 2025-09-04T11:53:28.000-07:00
diff --git a/pcb/hardware_tests/fan_gpio.py b/pcb/hardware_tests/fan_gpio.py
@@ -7,7 +7,7 @@
     'cam fan 1': 23,
     'cam fan 2': 24,
 }
-if pin not in valid_pins.values:
+if pin not in valid_pins.values():
     raise ValueError(f"Invalid pin, expected one of {valid_pins}")
 
 GPIO.setmode(GPIO.BCM)
diff --git a/pcb/hardware_tests/limit_switch_gpio.py b/pcb/hardware_tests/limit_switch_gpio.py
@@ -6,7 +6,7 @@
     'LS1': 18,
     'LS2': 15,
 }
-if pin not in valid_pins.values:
+if pin not in valid_pins.values():
     raise ValueError(f"Invalid pin, expected one of {valid_pins}")
 
 

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`'cam fan 1': 23,`
`8`	`8`	`'cam fan 2': 24,`
`9`	`9`	`}`
`10`		`-if pin not in valid_pins.values:`
	`10`	`+if pin not in valid_pins.values():`
`11`	`11`	`raise ValueError(f"Invalid pin, expected one of {valid_pins}")`
`12`	`12`
`13`	`13`	`GPIO.setmode(GPIO.BCM)`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`'LS1': 18,`
`7`	`7`	`'LS2': 15,`
`8`	`8`	`}`
`9`		`-if pin not in valid_pins.values:`
	`9`	`+if pin not in valid_pins.values():`
`10`	`10`	`raise ValueError(f"Invalid pin, expected one of {valid_pins}")`
`11`	`11`
`12`	`12`