Skip to content

Commit 01be3ea

Browse files
czlonkowskiclaude
andcommitted
fix: eliminate verified validator false positives across all rule families (Concieved by Romuald Członkowski - www.aiadvisors.pl/en)
A systematic audit validated 1,116 recent published n8n.io templates under all four profiles and inventoried all 439 validator rule emission points: 78% of published templates were declared invalid, with the dominant error classes 90-100% false positives (each class adversarially verified with live n8n reproductions before fixing). Fixes in this release: - applyNodeDefaults is visibility-aware (fixpoint), ending wrong-resource operation defaults that fabricated "Invalid value for operation" errors - error-handling style checks are lint, not validity: responseNode error removed, onError/error-output checks node-type-aware via getMainOutputCount - template-literal ${} in expressions is valid (real fix for #338); stale "common mistakes" warnings (optional chaining, bracket access) removed - IF/Switch/Filter structure checks are typeVersion/shape-aware; operator singleValue and conditions.options metadata no longer demanded - Merge input bounds, cycle detection, and bracket-balance checks respect n8n's lenient runtime behavior - Code scanner: tokenizer handles template-literal interpolation; bare-object returns valid in runOnceForAllItems; regex/SQL checks use word and statement boundaries (dropdown/updated_at/regex.exec no longer flagged) - AI validators check parameters the nodes actually have (sseEndpoint vs serverUrl, built-in tool descriptions, needsFallback dual models) - reachability BFS follows ai_* connections in reverse: AI sub-nodes of a reachable agent are reachable - nodes.db: extractFromFile restored; core-node completeness gate added to rebuild; optional-dep node modules no longer silently dropped; similarity suggester sentinel/category-match defects fixed - profile gating repaired: advisories gate to ai-friendly/strict; security/ deprecation warnings survive everywhere; severities recalibrated Result on the template corpus: falsely-invalid workflows 77% -> 39% (runtime), errors -39%, warnings -91%, and profiles differentiate again. ~150 new regression tests pin both directions (FP fixed, TP still fires). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 5834633 commit 01be3ea

42 files changed

Lines changed: 4561 additions & 751 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

CHANGELOG.md

Lines changed: 35 additions & 0 deletions

data/nodes.db

0 Bytes
Binary file not shown.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change

package.runtime.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change

src/loaders/node-loader.ts

Lines changed: 78 additions & 1 deletion
Original file line numberDiff line numberDiff line change

src/scripts/core-node-check.ts

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change

src/scripts/rebuild-optimized.ts

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change

src/scripts/rebuild.ts

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change

src/scripts/validate.ts

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change

src/services/ai-node-validator.ts

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change

0 commit comments

Comments
 (0)