Commit d80fb95
committed
docs(survival): fix broken citations and three R-package claims
Addresses all five review findings.
Citations (2): `@kalbfleisch2002` does not exist in references.bib -- only
`kalbfleisch2011statistical` does -- so both sites rendered as a literal
`kalbfleisch2002?` on the preview. Repointed to the real key.
R-package claims (3), each checked against CRAN rather than against the
review:
- `icenReg` is described as "Cox-PH, proportional odds, and accelerated
failure time models ... semi and fully parametric", with no mention of
truncation. The prose claimed it was "specifically designed for
interval-censored data with truncation".
- `interval` is "Weighted Logrank Tests and NPMLE for Interval Censored
Data" -- nonparametric throughout. The prose claimed semi-parametric tools
and complex-sampling support.
- Log-logistic, log-normal and generalized gamma were said to fit "the AFT
or PH frameworks", one sentence after correctly stating that exponential
and Weibull are the only families that are both. They are AFT families;
log-logistic is additionally proportional-odds.
The list's framing changed too: only `flexsurv` handles delayed entry and
interval censoring together, so saying all three "must be used" for that
combination was wrong about the other two.
Adding the `interval` correction cited @fay2010exact, which was not in
references.bib -- the same defect this commit fixes. Added it, verified via
Crossref: Fay & Shaw, JSS 36(2), 2010, doi 10.18637/jss.v036.i02.
Adversarial review then caught three more, all fixed here:
- The `icenReg` rewrite overstated it in turn. CRAN restricts the fully
parametric option to the AFT models ("parametric only for accelerated
failure time models"); the text now says so.
- Line 54 still read "Using the Kalbfleisch and Prentice (2002)
parameterization", three lines below a citation that now renders 2011.
CLAUDE.md forbids plaintext author-date anyway, so it is now
`@kalbfleisch2011statistical` and the mismatch cannot recur.
- Two package bullets packed two sentences per source line.
A fourth round caught a citation regression this PR introduced rather than
inherited: the rewrite dropped the source URL that `main` attached to the
Terry Therneau quotation, leaving a direct attributed quote with nothing to
verify it against. Restored as a link on the attribution line, and confirmed
reachable (HTTP 200) and present in the render.
Local gate: `quarto render chapters/parametric-survival-models.qmd --to html`
succeeded (it needs `renv::install(".")` first, since the chapter loads data
via `fs::path_package("rme", ...)`); `lintr::lint()` clean. The rendered page
was then scanned for unresolved citations, unresolved crossrefs, KaTeX
errors, unexpanded macros and lists that failed to render: clean, and the
citation now renders "Kalbfleisch and Prentice 2011" rather than
"kalbfleisch2002?".
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>1 parent be50d48 commit d80fb95
2 files changed
Lines changed: 34 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
477 | 477 | | |
478 | 478 | | |
479 | 479 | | |
480 | | - | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
481 | 484 | | |
482 | 485 | | |
483 | 486 | | |
484 | | - | |
| 487 | + | |
485 | 488 | | |
486 | 489 | | |
487 | 490 | | |
| |||
633 | 636 | | |
634 | 637 | | |
635 | 638 | | |
636 | | - | |
| 639 | + | |
| 640 | + | |
637 | 641 | | |
638 | 642 | | |
639 | 643 | | |
640 | 644 | | |
641 | 645 | | |
642 | 646 | | |
643 | 647 | | |
644 | | - | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
645 | 653 | | |
646 | 654 | | |
647 | | - | |
648 | | - | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
649 | 664 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1920 | 1920 | | |
1921 | 1921 | | |
1922 | 1922 | | |
| 1923 | + | |
| 1924 | + | |
| 1925 | + | |
| 1926 | + | |
| 1927 | + | |
| 1928 | + | |
| 1929 | + | |
| 1930 | + | |
| 1931 | + | |
| 1932 | + | |
| 1933 | + | |
0 commit comments