Claude finished @d-morrison's task in 2m 58s —— View job

Issue #132: Review Request Handling

Read CLAUDE.md for repo-specific guidelines (no CLAUDE.md found)
Explore repository structure and GitHub Actions workflows
Understand current review request handling
Implement changes to claude.yml
Implement changes to claude-code-review.yml
Commit changes locally

Note: GitHub Apps cannot push changes to .github/workflows/ files (permission denied). The changes are committed locally but could not be pushed. You'll need to apply these changes manually — the exact diff is below.

Changes needed

claude.yml — add a "remove reviewer" step before Claude runs, and simplify the final step to always re-request (not just when commits were pushed):

+      - name: Remove review request from d-morrison while Claude is working
+        if: github.event.pull_request.number || github.event.issue.pull_request
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          PR_NUMBER="${{ github.event.pull_request.number || github.event.issue.number }}"
+          gh api -X DELETE \
+            "repos/${{ github.repository }}/pulls/$PR_NUMBER/requested_reviewers" \
+            -f "reviewers[]=d-morrison" || true
+
       - name: Run Claude Code
       ...

-      - name: Re-request review from d-morrison if Claude pushed commits
-        if: always() && (github.event.pull_request.number || github.event.issue.pull_request) && steps.head_before.outputs.sha != ''
+      - name: Re-request review from d-morrison when Claude finishes
+        if: always() && (github.event.pull_request.number || github.event.issue.pull_request)
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SHA_BEFORE: ${{ steps.head_before.outputs.sha }}
         run: |
           PR_NUMBER="${{ github.event.pull_request.number || github.event.issue.number }}"
-          SHA_AFTER=$(gh api "repos/${{ github.repository }}/pulls/$PR_NUMBER" --jq '.head.sha')
-          echo "before=$SHA_BEFORE  after=$SHA_AFTER"
-          if [ "$SHA_AFTER" != "$SHA_BEFORE" ]; then
-            echo "Claude pushed new commits; re-requesting review."
-            gh api -X POST \
-              "repos/${{ github.repository }}/pulls/$PR_NUMBER/requested_reviewers" \
-              -f "reviewers[]=d-morrison" || true
-          else
-            echo "No new commits on PR head; skipping re-request."
-          fi
+          echo "Re-requesting review from d-morrison."
+          gh api -X POST \
+            "repos/${{ github.repository }}/pulls/$PR_NUMBER/requested_reviewers" \
+            -f "reviewers[]=d-morrison" || true

claude-code-review.yml — change permission to write, add remove step before review, add re-request step at end:

     permissions:
       contents: read
-      pull-requests: read
+      pull-requests: write
       issues: read
       id-token: write

+      - name: Remove review request from d-morrison while Claude is reviewing
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          gh api -X DELETE \
+            "repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/requested_reviewers" \
+            -f "reviewers[]=d-morrison" || true
+
       - name: Run Claude Code Review
       ...

+      - name: Re-request review from d-morrison when Claude finishes reviewing
+        if: always()
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          echo "Re-requesting review from d-morrison."
+          gh api -X POST \
+            "repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/requested_reviewers" \
+            -f "reviewers[]=d-morrison" || true

Why these changes:

The "remove" step runs before Claude starts, so d-morrison won't see a pending review request while Claude is working
The "re-request" step runs if: always() so it fires even if Claude errors out, giving you a fresh review request every time Claude finishes
For claude.yml, the old final step only re-requested review when Claude pushed new commits — now it always re-requests when on a PR

You can grant the Claude GitHub App the workflows permission in your repo settings if you'd like Claude to be able to apply these changes directly in the future.

review request handling #132

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions