Backport changes for version 1.2

The major change is the addition of doInitialFull() to scan the full
2^32 possibilities. With some optimized routines and enhanced threading,
this makes it possible (although still slow) to operate without a starting
seed. Added a new config param to allow customization of this behavior,
although the default should work well.

Several minor bug fixes and cleanups that ought to have been in
their own commits.

Also, added tests.

Author: d0sboots

README.md

@@ -38,6 +38,19 @@ re-logging won't change it.
 - The "+X more" values become exact.
 - The tooltip changes to show the enchantment effects in white, without percentages (since they're all guaranteed now.)
 
+### V1.2 Feature: Working without a seed hint
+Normally, the server sends enough information in a single test-enchant to quickly rule out most possibilities. However, some
+custom Minecraft servers mask some of this information, which makes the mod's job much harder. You will know you are in this
+situation if, after seeming to narrow in on the seed, the text changes to "Calculating... 0%" and starts counting up
+slowly. This means the mod has detected that using the seed isn't working, so it's doing an exhaustive search of all possibilities,
+by replaying the objects you've already test-enchanted.
+
+If this happens, you can go do something else for a while - the process will take a minute or two. Leaving the
+enchanting altar (or even destroying it) won't lose your progress, although logging out will. You may need to try a slightly
+wider variety of items to pinpoint an exact seed, although usually the combo of "book, pants, boots, helmet, chest, sword, bow"
+is enough. (Another possibility if this happens is that the mod has a bug, or the server is using different mechanics for
+enchanting than the client is aware of. You'll know the difference because after the long calculation, you'll get an error message.)
+
 ## How it works
 Internally, Minecraft uses a [pseudorandom number generator](https://en.wikipedia.org/wiki/Pseudorandom_number_generator) (RNG for short)
 to determine which enchantments will be applied to an item. The state of this RNG is completely determined by a single 32-bit number,

java/io/github/d0sboots/enchantmentrevealer/ContainerEnchantmentWrapper.java

@@ -62,7 +62,7 @@ protected Slot addSlotToContainer(Slot slot) {
     @Override
     public boolean enchantItem(EntityPlayer playerIn, int id) {
         boolean val = super.enchantItem(playerIn, id);
-        if (val) {
+        if (val && lastObservation != null) {
             Observation observation = new Observation();
             System.arraycopy(lastObservation.levels, 0, observation.levels, 0, 3);
             observation.truncatedSeed = (short) id;

java/io/github/d0sboots/enchantmentrevealer/EnchantmentRevealer.java

@@ -30,7 +30,7 @@
 public class EnchantmentRevealer
 {
     public static final String MODID = "EnchantmentRevealer";
-    public static final String VERSION = "1.1";
+    public static final String VERSION = "1.2";
     public static boolean verbose = false;
 
     // Replacement for System.out that doesn't do anything. This is replaced by System.out if verbose is true.
@@ -40,7 +40,7 @@ public class EnchantmentRevealer
         @Override public void write(byte[] unused1, int unused2, int unused3) {}
     });
 
-    private final Events events = new Events();
+    private Events events;
     private boolean enableCommand = false;
 
     @EventHandler
@@ -59,6 +59,13 @@ public void init(FMLPreInitializationEvent event)
                 "If true, the /xpseed command will be enabled, allowing you to retrieve "
                 + "and set players' enchantment seeds directly.");
         enableCommand = prop.getBoolean();
+        prop = config.get(Configuration.CATEGORY_CLIENT, "useSeedHint", "sometimes",
+                "How to handle seed \"hint\" values from the server. On a vanilla server, these provide "
+                + "useful information that greatly speeds up the deduction process, but other servers "
+                + "may send garbage data instead. Setting this to \"always\" says to always trust the "
+                + "server provided value, while \"never\" means to ignore it. The default is \"sometimes\", "
+                + "which means try to use the seed, but recalculate as if \"never\" if it doesn't work.");
+        events = new Events(prop.getString());
 
         if (config.hasChanged()) {
             config.save();