feat: unified node selection, UI centering, and React error fixes (v1.7.2)

Author: d3mocide

README.md

@@ -1,4 +1,4 @@
-# meshRF 📡 v1.7.0
+# meshRF 📡 v1.7.2
 
 A professional-grade RF propagation and link analysis tool designed for LoRa Mesh networks (Meshtastic, Reticulum, Sidewinder). Built with **React**, **Leaflet**, and a high-fidelity **Geodetic Physics Engine**.
 

RELEASE_NOTES.md

@@ -1,5 +1,48 @@
 # Release Notes
 
+## v1.7.2 - Selection Logic & UI Polish
+
+This release unifies the node selection behavior, resolves critical event propagation bugs, and polishes the import notification UI for a more professional experience.
+
+### 📡 Selection Logic & Architecture
+
+- **Unified Selection Flow**: Consolidated map clicks and batch node selections into a single, high-reliability handler.
+- **Predictable Roles**: Selecting a 3rd node now consistently resets the sequence, making the new node the **TX** point.
+- **Double-Selection Prevention**:
+  - Blocked event propagation from UI panels to the map to prevent accidental "double-selection".
+  - Implemented a 100ms temporal guard to ignore rapid-fire duplicate events.
+- **React Performance**: Fixed a "Cannot update a component while rendering another" state warning by refactoring state update sequences.
+
+### 🎨 UI & UX Refinements
+
+- **Centered Notifications**: The "IMPORT SUCCESSFUL" popup is now visually centered over the map area, intelligently adjusting for sidebar state.
+- **Streamlined Feedback**: Removed the redundant "CLOSE" button from the import notification, relying on its auto-dismiss behavior for a zero-click workflow.
+- **Bug Fixes**: Resolved a `ReferenceError` in `BatchProcessing.jsx` related to inconsistent state access.
+
+---
+
+## v1.7.1 - Mobile UX & HUD Refinement
+
+This update focuses on polishing the HUD layout and significantly improving the mobile user experience for multi-step workflows like Batch Node analysis.
+
+### 🎨 HUD Layout & Aesthetics
+
+- **Off-Center Toolbar**: Relocated the main toolbar to `left: 20px` to create a modern, asymmetrical layout.
+- **Action Button Alignment**: Standardized action buttons (Lock, Clear Link, etc.) to `left: 60px`, maintaining clear separation from the sidebar toggle.
+- **Sidebar Toggle Centering**: Vertically aligned the sidebar toggle button with other HUD action elements for a balanced visual center at `top: 76px`.
+- **Global Zoom Standard**: Zoom controls are now consistently located in the `bottom-right` corner across all devices, eliminating toolbar overlap.
+
+### 📱 Mobile UI Enhancements
+
+- **Smart Panel Minimization**:
+  - The **Batch Nodes list** now automatically minimizes when a link is established, maximizing map visibility.
+  - Relocated the minimized Batch Nodes panel to the top-left area to prevent conflict with analysis result sheets.
+- **Link Analysis Summaries**:
+  - Added a compact "Status & Margin" live summary to the minimized header on mobile, allowing users to see results without expanding the full sheet.
+  - Refined the "Grab Handle" and minimized height (`72px`) for a more responsive feel.
+
+---
+
 ## v1.7.0 - Pro RF Coverage & Runtime Config
 
 This major release introduces a powerful new **RF Coverage Tool** with stitched multi-tile analysis and draggable transmitters, alongside significant DevOps improvements for runtime configuration.

libmeshrf/include/meshrf_coverage.h

@@ -29,6 +29,7 @@ std::vector<float> calculate_rf_coverage(
     int tx_x,
     int tx_y,
     float tx_h_meters,
+    float rx_h_meters,
     float frequency_mhz,
     float tx_power_dbm,
     float tx_gain_dbi,

libmeshrf/js/meshrf.wasm

@@ -51,6 +51,7 @@ EMSCRIPTEN_BINDINGS(meshrf_module) {
         int tx_x,
         int tx_y,
         float tx_h,
+        float rx_h,
         float freq_mhz,
         float tx_power_dbm,
         float tx_gain_dbi,
@@ -61,7 +62,7 @@ EMSCRIPTEN_BINDINGS(meshrf_module) {
     ) {
         float* elev = reinterpret_cast<float*>(elev_ptr);
         return calculate_rf_coverage(
-            elev, width, height, tx_x, tx_y, tx_h,
+            elev, width, height, tx_x, tx_y, tx_h, rx_h,
             freq_mhz, tx_power_dbm, tx_gain_dbi, rx_gain_dbi,
             rx_sensitivity, max_dist, gsd_meters
         );

libmeshrf/src/bindings.cpp

@@ -11,6 +11,7 @@ std::vector<float> calculate_rf_coverage(
     int tx_x,
     int tx_y,
     float tx_h_meters,
+    float rx_h_meters,
     float frequency_mhz,
     float tx_power_dbm,
     float tx_gain_dbi,
@@ -77,7 +78,7 @@ std::vector<float> calculate_rf_coverage(
             LinkParameters params;
             params.frequency_mhz = frequency_mhz;
             params.tx_height_m = tx_h_meters;
-            params.rx_height_m = 2.0; // Default RX antenna height (can be parameterized later)
+            params.rx_height_m = rx_h_meters; // Use parameterized RX height
             params.polarization = 1; // Vertical (typical for LoRa)
             params.step_size_m = gsd_meters;
             params.N_0 = 301.0; // Standard atmosphere

libmeshrf/src/meshrf_coverage.cpp

@@ -1,6 +1,5 @@
 import numpy as np
 import math
-# tile_manager import removed
 
 # Constants
 EARTH_RADIUS_KM = 6371.0
@@ -60,14 +59,11 @@ def analyze_link(elevs, dist_m, freq_mhz, tx_h, rx_h):
     tx_alt = elevs[0] + tx_h # Height above sea level (no bulge at 0)
     rx_alt = elevs[-1] + rx_h # Height above sea level
 
-    # Linear interpolation of LOS height across the path (ignoring bulge on LOS itself since it's the reference usually?)
-    # Wait, if terrain is bulged, LOS is straight line?
-    # Yes, standard method: Terrain += Bulge, Link = Straight Line.
+    # Linear interpolation of LOS height across the path
 
     los_h = np.linspace(tx_alt, rx_alt, num_points)
 
     # 3. Fresnel Clearance
-    # clearance = los_h - terrain_h
     clearance = los_h - terrain_h
 
     # Fresnel Radius at each point
@@ -104,20 +100,3 @@ def analyze_link(elevs, dist_m, freq_mhz, tx_h, rx_h):
         "path_loss_db": 0.0, # Placeholder for ITM
         "profile": elevs.tolist()  # Return raw profile for debug?
     }
-
-def calculate_itm_loss(dist_m, elevs, freq_mhz, tx_h, rx_h):
-    try:
-        import itmlogic
-        # Placeholder: Check actual ITM API. 
-        # Assuming itmlogic.p2p(dist_km, profile, freq, h1, h2, ...)
-        # Since I cannot verify the API at this exact second without "search_web" deep dive,
-        # I will fall back to a robust simulation or basic models if import fails.
-        # But let's try to simulate calling it.
-        pass
-    except ImportError:
-        pass
-        
-    dist_km = dist_m / 1000
-    if dist_km < 0.001: return 0
-    fspl = 20 * math.log10(dist_km) + 20 * math.log10(freq_mhz) + 32.44
-    return fspl

public/meshrf.wasm

@@ -23,24 +23,22 @@ const Sidebar = () => {
         batchNodes, setBatchNodes,
         setShowBatchPanel,
         triggerRecalc,
-        editMode, setEditMode
+        editMode, setEditMode,
+        rxHeight, setRxHeight,
+        toolMode,
+        sidebarIsOpen, setSidebarIsOpen,
+        isMobile
     } = useRF();
 
-    // Responsive & Collapse Logic
-    const [isMobile, setIsMobile] = useState(window.innerWidth < 768);
-    const [isOpen, setIsOpen] = useState(window.innerWidth > 768);
     const [isSettingsOpen, setIsSettingsOpen] = useState(false);
 
+    // Initial sync
     useEffect(() => {
-        const handleResize = () => {
-            const mobile = window.innerWidth < 768;
-            setIsMobile(mobile);
-            if (mobile && isOpen) setIsOpen(false);
-            if (!mobile && !isOpen) setIsOpen(true);
-        };
-        window.addEventListener('resize', handleResize);
-        return () => window.removeEventListener('resize', handleResize);
-    }, []);
+        if (isMobile && sidebarIsOpen) setSidebarIsOpen(false);
+    }, [isMobile]); // Add dependency
+
+    const isOpen = sidebarIsOpen;
+    const setIsOpen = setSidebarIsOpen;
 
     const handleTxPowerChange = (e) => {
         setTxPower(Math.min(Number(e.target.value), DEVICE_PRESETS[selectedDevice].tx_power_max));
@@ -96,7 +94,7 @@ const Sidebar = () => {
         title={isOpen ? "Collapse Sidebar" : "Expand Sidebar"}
         style={{
             position: isMobile ? 'fixed' : 'absolute', // Stay with sidebar
-            top: '85px',
+            top: '76px',
             left: isOpen ? '330px' : '15px', // Floating to the right
             zIndex: 2010, // Above sidebar (2000)
             background: 'var(--color-primary)',
@@ -373,6 +371,27 @@ const Sidebar = () => {
             style={{width: '100%', cursor: 'pointer', accentColor: 'var(--color-primary)'}}
         />
 
+        {/* RX Height Slider - Only for RF Coverage Tool */}
+        {toolMode === 'rf_coverage' && (
+            <div style={{marginTop: 'var(--spacing-md)'}}>
+                <label style={labelStyle} htmlFor="rx-height">
+                    Receiver Height: {units === 'imperial' ? `${(rxHeight * 3.28084).toFixed(0)} ft` : `${rxHeight} m`}
+                    <span style={{color: 'var(--color-text-muted)', marginLeft: '8px', fontSize: '0.8em'}}>
+                        ({rxHeight <= 2 ? 'Handheld' : rxHeight <= 5 ? 'Vehicle' : 'Mast'})
+                    </span>
+                </label>
+                <input 
+                    id="rx-height"
+                    name="rx-height"
+                    type="range" 
+                    min="1" max="30" steps="1"
+                    value={rxHeight} 
+                    onChange={(e) => setRxHeight(Number(e.target.value))}
+                    style={{width: '100%', cursor: 'pointer', accentColor: 'var(--color-secondary)'}} 
+                />
+            </div>
+        )}
+
         {/* ERP CALCULATION DISPLAY */}
         <div style={{
             marginTop: 'var(--spacing-md)',