core: NFS4Client: Use Opaque.forBytes

Previously, we were using "new Opaque(bytes[])", which creates a new
Opaque instance backed by the given byte[].

Since the Opaque key may be used in a "owners" hashmap, make sure that
this information cannot be modified by the caller.

Use the immutable "Opaque.forBytes" instead.

Related: #149
Signed-off-by: Christian Kohlschütter <[email protected]>

Author: kohlschuetter

core/src/main/java/org/dcache/nfs/v4/NFS4Client.java

@@ -628,7 +628,7 @@ public boolean isCallbackNeede() {
     public synchronized StateOwner getOrCreateOwner(byte[] owner, seqid4 seq) throws BadSeqidException {
         StateOwner stateOwner;
         if (_minorVersion == 0) {
-            Opaque k = new Opaque(owner);
+            Opaque k = Opaque.forBytes(owner);
             stateOwner = _owners.get(k);
             if (stateOwner == null) {
                 state_owner4 so = new state_owner4();
@@ -655,7 +655,7 @@ public synchronized StateOwner getOrCreateOwner(byte[] owner, seqid4 seq) throws
      * @param owner client unique state owner
      */
     public synchronized void releaseOwner(byte[] owner) throws StaleClientidException {
-        Opaque k = new Opaque(owner);
+        Opaque k = Opaque.forBytes(owner);
         StateOwner stateOwner = _owners.remove(k);
         if (stateOwner == null) {
             throw new StaleClientidException();