feat(drawer): deprecate noBodyStyles and preventScrollRestoration#1649
Open
te6-in wants to merge 1 commit into
Open
feat(drawer): deprecate noBodyStyles and preventScrollRestoration#1649te6-in wants to merge 1 commit into
te6-in wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 08a64cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDrawer의 ChangesDrawer props deprecation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Alpha Preview (Stackflow SPA)
|
Contributor
Alpha Preview (Storybook)
|
Contributor
Alpha Preview (Docs)
|
te6-in
force-pushed
the
feat/drawer-deprecate-body-lock-props
branch
from
56504d9 to
6822197
Compare
Mark the vaul-derived noBodyStyles/preventScrollRestoration options on UseDrawerProps as @deprecated ahead of their removal in SEED React 1.3. On the current 1.2.x line these options still work: they feed usePositionFixed, so noBodyStyles={false} applies vaul's body position:fixed scroll lock and preventScrollRestoration controls scroll restoration on close. In 1.3 usePositionFixed is removed and the modal scroll lock moves entirely to usePreventScroll; both options are then ignored and behave as if pinned to their defaults (noBodyStyles=true, preventScrollRestoration=false). Upgrading to 1.3 changes behavior only for code that explicitly set noBodyStyles={false}. Mirrors the AppBar divider deprecation (1.2.x -> 1.3.0). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
te6-in
force-pushed
the
feat/drawer-deprecate-body-lock-props
branch
from
6822197 to
08a64cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Drawer/BottomSheet의noBodyStyles및preventScrollRestoration옵션을 deprecated 처리(제거 예정 버전: 1.3).noBodyStyles=true,preventScrollRestoration=false).