Skip to content

feat(lynx): add accessibility props type and conventions#1652

Open
junghyeonsu wants to merge 2 commits into
devfrom
lynx-accessibility-conventions
Open

feat(lynx): add accessibility props type and conventions#1652
junghyeonsu wants to merge 2 commits into
devfrom
lynx-accessibility-conventions

Conversation

@junghyeonsu

@junghyeonsu junghyeonsu commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Lynx 접근성 인프라 — 컴포넌트별 a11y 적용을 위한 공통 타입 + 컨벤션 문서. (컴포넌트 실제 적용은 후속 PR)

Changes

  • LynxAccessibilityProps (packages/lynx-react/src/types.ts): @lynx-js/types StandardProps의 accessibility 속성(accessibility-label/traits/element/value/role-description/elements-hidden/heading/actions/exclusive-focus/ios-platform-accessibility-id)을 표준화. 모든 native tag 공통(tag별 차이 없음 확인) → 컴포넌트가 확장해 native에 패스스루.
  • create-component lynx-patterns.md "Accessibility" 섹션: 속성 레퍼런스 표, web aria ↔ Lynx 매핑, 결정 트리(interactive/decorative/image/layout), headless(상태만) ↔ styled(a11y 직접 작성) 책임 분리, 예시.

Notes

  • web ARIA 대부분 대응 가능: aria-labelaccessibility-label, roleaccessibility-role-description, aria-checkedaccessibility-value, aria-hiddenaccessibility-elements-hidden.
  • accessibility-traits는 단일 값 → 역할은 role-description, 상태는 value로 분담.
  • 헬퍼는 두지 않음(컴포넌트마다 label/role/value가 달라 직접 작성이 명확).

Out of scope (후속 PR)

  • 컴포넌트별 a11y 적용 (ActionButton aria-labelaccessibility-label, Checkbox/Switch role 등)
  • docs/content/lynx 사용자 가이드

Verification

  • lynx-react typecheck + build green

🤖 Generated with Claude Code

Summary by CodeRabbit

주요 변경사항

  • 새로운 기능

    • 접근성 속성의 표준화를 통해 컴포넌트에서 네이티브 엘리먼트로 접근성 레이블, 역할 설명, 값 등을 더욱 일관성 있게 전달할 수 있습니다.
  • 문서

    • Lynx 접근성 패턴에 대한 포괄적인 가이드가 추가되었으며, 속성 매핑, 이벤트, 메서드, 책임 분리 원칙, 그리고 실제 사용 예시를 포함합니다.

junghyeonsu and others added 2 commits June 9, 2026 17:42
…ions

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 45e7d00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@seed-design/lynx-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 82362e9a-5b9b-4b25-8400-dc7cb53c396a

📥 Commits

Reviewing files that changed from the base of the PR and between bf60655 and 45e7d00.

📒 Files selected for processing (3)
  • .changeset/lynx-accessibility-props.md
  • packages/lynx-react/src/types.ts
  • skills/create-component/references/lynx-patterns.md

📝 Walkthrough

Walkthrough

@seed-design/lynx-react 패키지에 LynxAccessibilityProps 타입을 추가하여 네이티브 엘리먼트의 접근성 속성을 표준화합니다. 타입 정의, 릴리스 노트, 그리고 접근성 속성 사용 가이드 문서를 함께 제공합니다.

Changes

Lynx 접근성 속성 표준화 및 문서화

Layer / File(s) Summary
LynxAccessibilityProps 타입 정의
packages/lynx-react/src/types.ts
Lynx 네이티브 엘리먼트(<view>, <text>, <image> 등)가 공유하는 접근성 속성을 Pick<LynxViewProps, ...>로 정의하고, Lynx 및 웹 ARIA 표준 간 플랫폼 매핑을 주석으로 설명합니다.
릴리스 공지 및 접근성 사용 패턴 문서
.changeset/lynx-accessibility-props.md, skills/create-component/references/lynx-patterns.md
Minor 버전 변경을 선언하는 Changeset을 추가하고, Accessibility 섹션에서 표준 속성 레퍼런스 표, 이벤트/메서드, 책임 분리(lynx-headless vs lynx-react), 컴포넌트 타입별 결정 트리, 그리고 TSX 구현 예시를 문서화합니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 접근성을 꼬리 쪽까지 챙기고,
속성 타입으로 선명하게 정의하여,
네이티브 엘리먼트들이 모두 손쉽게
웹 표준과 만날 수 있도록,
세밀한 문서와 함께 준비했네요! 🎯✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Pull request 제목이 변경사항의 주요 내용을 정확하게 요약합니다: Lynx 접근성 속성 타입과 컨벤션을 추가하는 것이 핵심 변경사항입니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lynx-accessibility-conventions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@junghyeonsu junghyeonsu self-assigned this Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant