feat(lynx): add accessibility props type and conventions#1652
feat(lynx): add accessibility props type and conventions#1652junghyeonsu wants to merge 2 commits into
Conversation
…ions Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 45e7d00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
ChangesLynx 접근성 속성 표준화 및 문서화
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Lynx 접근성 인프라 — 컴포넌트별 a11y 적용을 위한 공통 타입 + 컨벤션 문서. (컴포넌트 실제 적용은 후속 PR)
Changes
LynxAccessibilityProps(packages/lynx-react/src/types.ts):@lynx-js/typesStandardProps의 accessibility 속성(accessibility-label/traits/element/value/role-description/elements-hidden/heading/actions/exclusive-focus/ios-platform-accessibility-id)을 표준화. 모든 native tag 공통(tag별 차이 없음 확인) → 컴포넌트가 확장해 native에 패스스루.lynx-patterns.md"Accessibility" 섹션: 속성 레퍼런스 표, web aria ↔ Lynx 매핑, 결정 트리(interactive/decorative/image/layout), headless(상태만) ↔ styled(a11y 직접 작성) 책임 분리, 예시.Notes
aria-label→accessibility-label,role→accessibility-role-description,aria-checked→accessibility-value,aria-hidden→accessibility-elements-hidden.accessibility-traits는 단일 값 → 역할은role-description, 상태는value로 분담.Out of scope (후속 PR)
aria-label→accessibility-label, Checkbox/Switch role 등)Verification
🤖 Generated with Claude Code
Summary by CodeRabbit
주요 변경사항
새로운 기능
문서