Skip to content

fix(registry): scope docs registry output under react framework path (1.0)#1658

Open
junghyeonsu wants to merge 1 commit into
1.0from
backport/registry-react-scope-1.0
Open

fix(registry): scope docs registry output under react framework path (1.0)#1658
junghyeonsu wants to merge 1 commit into
1.0from
backport/registry-react-scope-1.0

Conversation

@junghyeonsu

Copy link
Copy Markdown
Contributor

Why

The latest @seed-design/cli resolves snippets from {baseUrl}/__registry__/{framework}/... (introduced on dev by #1591 + Lynx work). The 1.0 maintenance deploy (1-0.seed-design.pages.dev) still served the legacy flat layout {baseUrl}/__registry__/{ui,lib,breeze}/..., so @seed-design/cli@latest add-all ... --baseUrl https://1-0.seed-design.pages.dev broke.

Backport of #1591 (react portion only) for DES-1932. Companion to the 1.1 backport (#1657).

What

  • Re-path the generated registry output from public/__registry__/{ui,lib,breeze}/... to public/__registry__/react/... (pure move; component JSON content unchanged).
  • Add a top-level public/__registry__/index.json advertising the react framework.
  • Update docs/scripts/generate-registry.ts to emit the framework-scoped layout (so future bun generate:registry reproduces it).
  • Point manual-installation.tsx / breeze-manual-installation.tsx at the new react/ paths.

Excluded (intentionally)

  • lynx — this branch has no lynx components; advertising it would make the CLI request a non-existent lynx/ registry (404).
  • CLI (packages/cli) — published from main/dev, not from maintenance branches.
  • generate-docs-index.ts (absent here), commands.mdx (its GitHub-raw example targets the source docs/registry/ which stays flat on this branch), and the block registry (absent here).

Verification

  • react/ json count == previous flat count (41 == 41); pure re-path, no content change.
  • Maps exactly to the latest CLI fetch URLs: fetchAvailableRegistries__registry__/react/index.json, fetchRegistry__registry__/react/{id}/index.json, item → __registry__/react/{id}/{item}.json.
  • After merge: confirm Cloudflare Pages rebuilds and https://1-0.seed-design.pages.dev/__registry__/react/index.json resolves.

🤖 Generated with Claude Code

Backport of #1591 (react portion) for DES-1932.

The latest @seed-design/cli resolves snippets from
`{baseUrl}/__registry__/{framework}/...`, but the 1.0 maintenance deploy
(1-0.seed-design.pages.dev) still served the legacy flat layout
`{baseUrl}/__registry__/{ui,lib,breeze}/...`, breaking `add-all --baseUrl`.

- Re-path the generated registry under `react/` and add a top-level
  `__registry__/index.json` advertising the react framework.
- Update generate-registry.ts to emit the framework-scoped layout.
- Point the manual-installation consumers at the new react/ paths.

lynx is intentionally excluded: this branch has no lynx components, and
advertising it would make the CLI request a non-existent lynx/ registry.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4be39749-49b1-4360-8da3-af8e0ebbc32c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch backport/registry-react-scope-1.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot

changeset-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 843fd36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@junghyeonsu junghyeonsu self-assigned this Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant