remove 'custom.css' argument

Author: daattali

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: shinycssloaders
 Title: Add Loading Animations to a 'shiny' Output While It's Recalculating
-Version: 1.1.0.9003
+Version: 1.1.0.9004
 Authors@R: c(
     person("Dean","Attali",email="[email protected]",role=c("aut","cre"),
         comment = c("Maintainer/developer of shinycssloaders since 2019", ORCID="0000-0002-5645-3493")),

NEWS.md

@@ -1,5 +1,6 @@
 # Unreleased version
 
+- **BREAKING CHANGE** Remove `custom.css` argument that has almost no usage. If you still want to achieve a similar behaviour, use `type=0` 
 - Add `delay` argument to show the spinner after a short delay (#95)
 - Add `inline` argument to allow displaying spinner inline (#25)
 - Add `width` argument that can be used in rare cases where the spinner has no inherent width (#85)

R/buildSpinner.R

@@ -5,7 +5,6 @@ buildSpinner <- function(
     color,
     size,
     color.background,
-    custom.css,
     proxy.height,
     id,
     image,
@@ -29,16 +28,12 @@ buildSpinner <- function(
   if (grepl("rgb", color, fixed = TRUE)) {
     stop("shinycssloaders: `color` should be given in hex format (#XXXXXX).")
   }
-  if (is.character(custom.css)) {
-    stop("shinycssloaders: It looks like you provided a string to `custom.css`, but it needs to be either `TRUE` or `FALSE`. ",
-         "The actual CSS needs to added to the app's UI.")
-  }
 
   if (is.null(id)) {
     id <- paste0("spinner-", digest::digest(ui_element))
   }
 
-  css_rules_tag <- get_spinner_css_tag(type, color, size, color.background, custom.css, id,
+  css_rules_tag <- get_spinner_css_tag(type, color, size, color.background, id,
                                        image, caption, width, output_spinner)
 
   if (!is.null(caption)) {

R/pageSpinner.R

@@ -68,7 +68,6 @@ showPageSpinner <- function(
     color = getOption("page.spinner.color", default = "#0275D8"),
     size = getOption("page.spinner.size", default = 1),
     color.background = getOption("page.spinner.color.background"),
-    custom.css = getOption("page.spinner.custom.css", default = FALSE),
     id = getOption("page.spinner.id"),
     image = getOption("page.spinner.image"),
     image.width = getOption("page.spinner.image.width"),
@@ -88,7 +87,6 @@ showPageSpinner <- function(
     color = color,
     size = size,
     color.background = color.background,
-    custom.css = custom.css,
     id = id,
     image = image,
     image.width = image.width,

R/utils.R

@@ -65,9 +65,9 @@ get_proxy_element <- function(ui_element, proxy.height, hide.ui) {
   }
 }
 
-get_spinner_css_tag <- function(type, color, size, color.background, custom.css, id, image, caption, width, output_spinner) {
+get_spinner_css_tag <- function(type, color, size, color.background, id, image, caption, width, output_spinner) {
   base_css <- ""
-  add_default_style <- (is.null(image) && !custom.css && type != 0)
+  add_default_style <- (is.null(image) && type != 0)
   if (add_default_style) {
     if (type %in% c(2, 3) && is.null(color.background)) {
       stop("shinycssloaders: For spinner types 2 & 3 you need to specify `color.background`.")

R/withSpinner.R

@@ -16,8 +16,6 @@
 #' Ignored if `image` is used.
 #' @param color.background For certain spinners (type 2-3), you will need to specify the background color of the spinner.
 #' Ignored if `image` is used.
-#' @param custom.css Set to `TRUE` if you have your own custom CSS that you defined and you don't want the automatic CSS applied to the spinner.
-#' Ignored if `image` is used.
 #' @param proxy.height If the output UI doesn't specify the output height, you can set a proxy height. For example, `textOutput()` usually needs this parameter. It defaults to "400px"
 #' for outputs with undefined height. Ignored if `hide.ui` is set to `FALSE`.
 #' @param id The HTML ID to use for the spinner. If you don't provide one, it will be generated automatically.
@@ -64,7 +62,6 @@ withSpinner <- function(
   color = getOption("spinner.color", default = "#0275D8"),
   size = getOption("spinner.size", default = 1),
   color.background = getOption("spinner.color.background"),
-  custom.css = getOption("spinner.custom.css", default = FALSE),
   proxy.height = getOption("spinner.proxy.height"),
   id = NULL,
   image = getOption("spinner.image"),
@@ -88,7 +85,6 @@ withSpinner <- function(
     color = color,
     size = size,
     color.background = color.background,
-    custom.css = custom.css,
     proxy.height = proxy.height,
     id = id,
     image = image,